Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions: Push notifications display user mentions differently #1451

Closed
Tracked by #2065
Velin92 opened this issue Sep 28, 2023 · 0 comments · Fixed by #1846
Closed
Tracked by #2065

Mentions: Push notifications display user mentions differently #1451

Velin92 opened this issue Sep 28, 2023 · 0 comments · Fixed by #1846
Assignees
@jmartinesp
Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design

Comments

@Velin92
Copy link
Member

Velin92 commented Sep 28, 2023 •
edited
Loading

From element-x-ios created by Velin92: element-hq/element-x-ios#1825

Mentions should be displayed with @username in the notification (however since the username is usually not available in the notification context, is also okay to prefix with @ the hyperlink text just to make it clear that is a mention from the notification)

Also if you have been mentioned in the notification we should prefix the notification body with:
"Username mentioned you"
or
"You have been mentioned" if the username of the sender is not available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinesp jmartinesp

Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add special notifications for mentions element-hq/element-x-android
2 participants
@jmartinesp @Velin92