Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have to press Enter twice to send a message that ends with unwanted autocomplete #9876

Closed
turt2live opened this issue May 28, 2019 · 8 comments

Comments

@turt2live
Copy link
Member

For example, 'hello world :)' requires two Enter presses, despite me not wanting to use the emoji-emoji (just the smiley as two characters). I do not have autoreplace plaintext emoji with real emoji enabled.

@turt2live
Copy link
Member Author

also applies if your message ends with a colon at all.

@turt2live turt2live changed the title Have to press Enter twice to send a message that ends in plain emoji Have to press Enter twice to send a message that ends with unwanted autocomplete May 28, 2019
@turt2live
Copy link
Member Author

... and if you say #anything at the end...

@ara4n
Copy link
Member

ara4n commented May 28, 2019

is this a regression?

@turt2live
Copy link
Member Author

On develop, yes

@ara4n
Copy link
Member

ara4n commented May 29, 2019

right, it's biting me now too. annoying.

@bwindels
Copy link
Contributor

This must be matrix-org/matrix-react-sdk#2968, which was a fix for #4721

Maybe the solution is to only capture Enter while autocompleting when you've actually auto-completed (e.g. the text you typed has been replaced with an emoji, selectionOffset > 0)?

@turt2live
Copy link
Member Author

That solution sounds like the right thing to me, although I think it'd make sense to also capture Enter when your selection changes from 0 -> 1 -> 0 again

@lampholder
Copy link
Member

Slack handles this in quite a nice way.

  • Ending your message with an emoticon:
    Slack doesn't update the composer, but your emoticon will have been replaced with the corresponding emoji when it enters the timeline
    (Otherwise, Slack replaces emoticons with emoji on space (not other non-word characters, though - comma, semicolon etc. do not trigger a substitution)

  • Ending your message with a colon:
    Slack doesn't initiate emoji-autocomplete until you've type :xx - i.e. colon and two characters. This stops emoticons triggering unwanted autocomplete suggestions, and means ending a message with colon is fine (since a colon by itself doesn't trigger autocomplete)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants