permalinkCreator is marked as required in ReplyThread but it is undefined

[turt2live]

Found in a rageshake:

2019-02-28T15:40:48.508Z E Warning: Failed prop type: The prop `permalinkCreator` is marked as required in `ReplyThread`, but its value is `undefined`.
    in ReplyThread (created by EventTile)
    in EventTile (created by withMatrixClient<EventTile>)
    in withMatrixClient<EventTile> (created by ReplyPreview)
    in div (created by ReplyPreview)
    in div (created by ReplyPreview)
    in ReplyPreview (created by MessageComposerInput)
    in div (created by MessageComposerInput)
    in div (created by MessageComposerInput)
    in MessageComposerInput (created by MessageComposer)
    in div (created by MessageComposer)
    in div (created by MessageComposer)
    in div (created by MessageComposer)
    in MessageComposer (created by RoomView)
    in div (created by RoomView)
    in MainSplit (created by RoomView)
    in main (created by RoomView)
    in RoomView (created by LoggedInView)
    in div (created by LoggedInView)
    in DragDropContext (created by LoggedInView)
    in div (created by LoggedInView)
    in LoggedInView (created by MatrixChat)
    in MatrixChat

[t3chguy]

permalinkCreator is not even a defined PropType on EventTile :(

[lampholder]

Is this causing any problems to the user?

[t3chguy]

It'd mean the permalink in the ReplyThread (on the timestamp or maybe on the context menu) would not be possible to generate

[jryans]

Fixed by matrix-org/matrix-react-sdk#2729

[jryans]

I am still seeing this original stack after making a new test account.

[turt2live]

Are you sure it's not on ReplyPreview? (#9042)

[jryans]

Are you sure it's not on ReplyPreview? (#9042)

Yes, here's the one I have now:

Warning: Failed prop type: The prop `permalinkCreator` is marked as required in `ReplyThread`, but its value is `undefined`.
    in ReplyThread (created by EventTile)
    in EventTile (created by withMatrixClient<EventTile>)
    in withMatrixClient<EventTile> (created by MessagePanel)
    in li (created by MessagePanel)
    in ol (created by ScrollPanel)
    in div (created by ScrollPanel)
    in div (created by GeminiScrollbar)
    in div (created by GeminiScrollbar)
    in GeminiScrollbar (created by GeminiScrollbarWrapper)
    in GeminiScrollbarWrapper (created by ScrollPanel)
    in ScrollPanel (created by MessagePanel)
    in MessagePanel (created by TimelinePanel)
    in TimelinePanel (created by RoomView)
    in div (created by RoomView)
    in div (created by RoomView)
    in div (created by MainSplit)
    in MainSplit (created by RoomView)
    in main (created by RoomView)
    in RoomView (created by LoggedInView)
    in div (created by LoggedInView)
    in DragDropContext (created by LoggedInView)
    in div (created by LoggedInView)
    in LoggedInView (created by MatrixChat)
    in MatrixChat

which seems the same as the original comment here.

[turt2live]

Well, that's fun 🙃

[jryans]

I think the root cause is that RoomView's onRoom stores the new room in state (triggering a render of sub-components), and then in a later step, _onRoomLoaded creates the permalinkCreator, which also stored in state.

The one render in the middle that has a room but no permalinkCreator can cause this error.

[jryans]

Well, I can't decide what to do here... Either we should ensure there's always a permalinkCreator by change when it's set, or relax the props to make it optional to allow for the brief moment when it may not be there.

[turt2live]

I believe this is fixed. If not, a new issue with more details is appreciated.