E2E: "set up new recovery options" UI for key backup confusing

[matthijskooijman]

Description

I just played around with the key backup, and was a bit confused. One of the things that confused me, was the "Set up new recovery options" UI.

This UI is offered when you click "Use key backup" on a new device or "Restore from backup" on a device that is already setup to use key backup:

When you click "set up new recovery options", you get this UI, which I believe is the same as when you start using key backup for the first time:

The wording "Set up new recovery options" suggested to me that this would extend the existing backup setup with more recovery options (e.g. to allow downloading the recovery key or change the passphrase). However, it seems that his instead completely replaces the existing backup setup. If you do this on an existing device, I believe it will just create a new backup, with the same contents, and a new passphrase and/or recovery key. However, if you do this on a new device, I believe it will replace the old backup, possibly deleting your key backups (or, at least, if older versions of backups are kept, making them harder to reach). This could use some more specific warnings, perhaps?

This might be related to my remark at #8814 (comment) that wonders whether the passphrase should really be a "recovery passphrase". If you don't think of it like this, then "set up recovery options" does not mean "set a new passphrase and/or recovery key".

Version information

https://riot.im/app
matrix-react-sdk version:
riot-web version: 1.0.1
olm version: 3.0.0

[kittykat]

I'm going to close this issue for now as the UI has changed significantly. If you are still experiencing the issue, please file a new one with details of what could be improved