-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Room sublist resizing, part II #8125
Comments
Ugh, flexbox doesn't actually buy us much, as we need to implement a layout model ourselves anyway because we want to enforcing a & b with flexbox only is not possible, so we might as well completely style the layout with box layout instead of flexbox |
when filtering, what do we do with the layout? if an item just keeps its size set to pixels, and only one sublist is shown, you get only a portion of the screen filled without a resize handle to see more. |
just jotting down my ideas here: we'd need a layout object that is created/owned by the RoomList. RoomList updates it when:
we'd pass the whole layout object to the resizer when starting to drag, and the resizer calls the layout object instead of manipulating the DOM directly. |
also, the last sublist (low prio) isn't considered at all right now by the resizer, but as the layout object would change the size of the sublist before and after a handle so everything still fits in the total space available, this would solve itself in that way. |
got something working on branch
|
As visible in these videos (1 2), when the total space requested by all sublists is > the available space, the layout starts act a little weird. To avoid requested size > available space, we'd have to do something like:
we'd need to have a layout model in js to know when the size is filled, consisting of:
would also make it possible to update the model easily when the available space changes
we'd build the model on mousedown from the DOM, and update it together with the DOM.
The text was updated successfully, but these errors were encountered: