Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental hangs a lot during catchup after sleep since the big merge #8033

Closed
ara4n opened this issue Jan 5, 2019 · 8 comments
Closed
Assignees

Comments

@ara4n
Copy link
Member

ara4n commented Jan 5, 2019

it now takes much longer for the app to be usable when unsleeping laptop - like, several minutes where it's not responsive and may trigger app not responding warnings

@turt2live
Copy link
Member

I'm betting on this being the room list re-sorting itself with every event. There's a TODO comment from years ago to make this better.

@ara4n
Copy link
Member Author

ara4n commented Jan 5, 2019

what got merged in the big merge which made this so much more apparent though?

@turt2live
Copy link
Member

The sort is a little bit more complicated, which adds up with each room. Multiply that by how many events need to be processed and React's (relatively) slow rendering time per tile, it can easily get into minutes for people in >1000 rooms.

The fix is to honour the TODO comment and track changes more closely instead of re-sorting the entire list every time.

@turt2live
Copy link
Member

This wasn't as noticeable on /develop because the vast majority of the room tiles would be hidden, making the rendering time per iteration significantly lower.

@ara4n
Copy link
Member Author

ara4n commented Jan 5, 2019

hum. we're going to need to fix this before it goes live.

@turt2live
Copy link
Member

fwiw it's on my radar but there's no reason why someone else can't do it.

@turt2live turt2live self-assigned this Jan 8, 2019
@turt2live
Copy link
Member

Taking this on as @ara4n's experience has degraded a lot in the last couple days, and I'm no longer able to communicate in 2 rooms simultaneously anymore.

I've given this the redesign label as it appears to only affect the redesign.

@turt2live
Copy link
Member

The core of this issue is fixed. Using #8122 to track future opportunity to improve the algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants