-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental hangs a lot during catchup after sleep since the big merge #8033
Comments
I'm betting on this being the room list re-sorting itself with every event. There's a TODO comment from years ago to make this better. |
what got merged in the big merge which made this so much more apparent though? |
The sort is a little bit more complicated, which adds up with each room. Multiply that by how many events need to be processed and React's (relatively) slow rendering time per tile, it can easily get into minutes for people in >1000 rooms. The fix is to honour the TODO comment and track changes more closely instead of re-sorting the entire list every time. |
This wasn't as noticeable on /develop because the vast majority of the room tiles would be hidden, making the rendering time per iteration significantly lower. |
hum. we're going to need to fix this before it goes live. |
fwiw it's on my radar but there's no reason why someone else can't do it. |
Taking this on as @ara4n's experience has degraded a lot in the last couple days, and I'm no longer able to communicate in 2 rooms simultaneously anymore. I've given this the redesign label as it appears to only affect the redesign. |
The core of this issue is fixed. Using #8122 to track future opportunity to improve the algorithm. |
it now takes much longer for the app to be usable when unsleeping laptop - like, several minutes where it's not responsive and may trigger app not responding warnings
The text was updated successfully, but these errors were encountered: