Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redacting a pin event breaks the message context menu in that room #6635

Closed
tulir opened this issue Apr 29, 2018 · 1 comment · Fixed by matrix-org/matrix-react-sdk#4133
Closed

Redacting a pin event breaks the message context menu in that room #6635

tulir opened this issue Apr 29, 2018 · 1 comment · Fixed by matrix-org/matrix-react-sdk#4133
Assignees
@t3chguy
Labels
A-Redaction P3 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@tulir
Copy link
Contributor

tulir commented Apr 29, 2018

Steps to reproduce

  • Pin a message
  • Redact the event that pinned the message
  • Try to open a message context menu

Context menu does not open, console shows

TypeError: t.getContent(...).pinned is undefined @ MessageContextMenu.js:82:15

The context menu can be restored by manually sending a valid m.room.pinned_events event, such as {"pinned": []}

Version information
@lampholder
Copy link
Member

I expect us to be looking at pinned messages impl in the near future - we'll bear this in mind then.

@lampholder lampholder added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label May 3, 2018
@turt2live turt2live mentioned this issue Feb 11, 2019
Closed
@lampholder lampholder mentioned this issue May 15, 2023
Closed
14 tasks
@t3chguy t3chguy self-assigned this Feb 26, 2020
@t3chguy t3chguy mentioned this issue Feb 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Redaction P3 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix message context menu breaking on invalid m.room.pinned_events event matrix-org/matrix-react-sdk
4 participants
@jryans @lampholder @t3chguy @tulir