Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik URL tracking bugs #6601

Closed
lukebarnard1 opened this issue Apr 25, 2018 · 0 comments
Closed

Piwik URL tracking bugs #6601

lukebarnard1 opened this issue Apr 25, 2018 · 0 comments
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Apr 25, 2018

In the process of making our analytics indicate the true window.origin and redacted window.hash, I discovered some bugs with tracking for certain pages.

These bugs could have always existed, but potentially these are regressions. We don't know because there are no automated tests done on the analytics.

Bugs:

  • When clicking "settings" (from /groups or /room/!...), we track the URL that we were at previously. When closing settings we track the thing we view next - which is apparently always the previous room we were looking at.
  • When clicking "groups", we track the URL we were at previously.
  • When clicking "directory", we track the URL we were at previously.
  • When clicking "home", we track the URL we were at previously.

N.B. despite not tracking the above correctly, they may still appear in the stats because they might be "the URL we were at previously".

@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants