Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'anyone can join' communities #6399

Closed
lampholder opened this issue Mar 27, 2018 · 14 comments
Closed

Support for 'anyone can join' communities #6399

lampholder opened this issue Mar 27, 2018 · 14 comments

Comments

@lampholder
Copy link
Member

This feature is distinct from 'knocking' to request access to a community.

This feature supports:

  • community admins configuring their communities to allow anybody to join
  • users to join said communities
@lampholder
Copy link
Member Author

lampholder commented Mar 27, 2018

Community admin screen:
desktop 4

  • I would love to hear suggestions for better wording than 'Anyone'
    • EDIT: at the very least I prefer 'Everyone' to 'Anyone'
  • Also opportunistically redesigning the ambiguous 'Leave' button to read 'Leave this group'

EDIT: s/group/community/g

@lampholder
Copy link
Member Author

lampholder commented Mar 27, 2018

User joining screen:
desktop 3

  • Yes, the 'Join this group' is an a slightly aesthetically unpleasing location, but it mirrors the location for 'leave this group' when you view the group settings.
  • There is a case for the join button also to live behind group settings, but I think it would be favouring consistency over engagement (and hence a mistake).

EDIT: s/group/community/g

@lampholder
Copy link
Member Author

Sorry @turt2live - should just have added this stuff to #5242. Thanks for doing the tidying :)

@turt2live
Copy link
Member

No problem. Would rather the information be somewhere than nowhere anyways :p

I am a bit concerned about the placement of the join rules though. It's under the warning saying it'll take 30 minutes to appear. Surely this is a change that won't take 30 minutes to reach other people? (hopefully)

@lampholder
Copy link
Member Author

Hmm, you're right, it won't. I'll talk to @lukebarnard1 tomorrow about whether (due to the current impl) it might appear like the rules hadn't changed for ~30 minutes (I don't know whether we fetch the group details afresh upon opening the group - I expect we do).

Certainly though it won't take 30 minutes for your config change actually to affect people's ability to join.

@lampholder
Copy link
Member Author

lampholder commented Mar 28, 2018

Possible tiny improvement on the settings warning:
desktop 6

Edit: s/Anyone/Everyone/

I experimented with some other options (see https://www.figma.com/file/BC3S8Rhacn6oThrtpzeTgbZT/Join-anyone-can-join-community) - anything that radically repositioned the caveat text just looked even clunkier IMHO

@lampholder
Copy link
Member Author

An alternative to the join button that more closely mirrors room join UX:

desktop 1

s/looking at/something less stupid/

@turt2live
Copy link
Member

@lampholder what do you think about this?
image

(doesn't actually work, I just shoved a button into the dom)

@lampholder
Copy link
Member Author

I think aesthetically it's an improvement, but I see a few problems:

  • we only put 'save' buttons there today
  • on a narrower monitor the button will overlap the title/description
  • I'm fine with 'this' being absent from 'Join Community', though I think I would want to keep in 'Leave this community' and I like the symmertry between the two

Fwiw I'm not wild about the aesthetics of what I've proposed, but (for better or worse) it uses the existing UX language so I reckon we'll go with it for now :\

@ara4n
Copy link
Member

ara4n commented Mar 28, 2018

fwiw i assumed we'd so something like @turt2live's example, but probably with the button at the bottom of the group description text rather than lost in the top bar. I'm not sure the preview bar is going to make much sense, plus it's going to push the important content down the page for no good reason (and is fiddlier to do than just slapping a button in the page)

@lampholder
Copy link
Member Author

AH yes, that's actually what I meant :\

The green 'join...' was intended to mirror the position of the pink 'leave...' (so part of the header but beneath the name and description)

desktop

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 29, 2018

To summarise:

@turt2live
Copy link
Member

An added benefit to this would be to automatically enable flair when joining public communities. Anything to reduce the road to flair feels like an improvement to me.

@ara4n
Copy link
Member

ara4n commented Apr 13, 2018

this happened, and #6507 is @turt2live's last suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants