-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for 'anyone can join' communities #6399
Comments
EDIT: s/group/community/g |
Sorry @turt2live - should just have added this stuff to #5242. Thanks for doing the tidying :) |
No problem. Would rather the information be somewhere than nowhere anyways :p I am a bit concerned about the placement of the join rules though. It's under the warning saying it'll take 30 minutes to appear. Surely this is a change that won't take 30 minutes to reach other people? (hopefully) |
Hmm, you're right, it won't. I'll talk to @lukebarnard1 tomorrow about whether (due to the current impl) it might appear like the rules hadn't changed for ~30 minutes (I don't know whether we fetch the group details afresh upon opening the group - I expect we do). Certainly though it won't take 30 minutes for your config change actually to affect people's ability to join. |
Possible tiny improvement on the settings warning: Edit: s/Anyone/Everyone/ I experimented with some other options (see https://www.figma.com/file/BC3S8Rhacn6oThrtpzeTgbZT/Join-anyone-can-join-community) - anything that radically repositioned the caveat text just looked even clunkier IMHO |
@lampholder what do you think about this? (doesn't actually work, I just shoved a button into the dom) |
I think aesthetically it's an improvement, but I see a few problems:
Fwiw I'm not wild about the aesthetics of what I've proposed, but (for better or worse) it uses the existing UX language so I reckon we'll go with it for now :\ |
fwiw i assumed we'd so something like @turt2live's example, but probably with the button at the bottom of the group description text rather than lost in the top bar. I'm not sure the preview bar is going to make much sense, plus it's going to push the important content down the page for no good reason (and is fiddlier to do than just slapping a button in the page) |
To summarise:
|
An added benefit to this would be to automatically enable flair when joining public communities. Anything to reduce the road to flair feels like an improvement to me. |
this happened, and #6507 is @turt2live's last suggestion. |
This feature is distinct from 'knocking' to request access to a community.
This feature supports:
The text was updated successfully, but these errors were encountered: