-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian package for ARM #6153
Comments
The riot-web debian package is the electron build which is not just static files |
The issue you might want to comment on is #2777 |
Hmm, don't understand. You already provide Debian packages (so #2777 should be solved), so the only thing you'd need there is to ad ARM support. |
The packages you mentioned are of the electron build. No packages of just the static files are provided other than the tarballs on github. Riot-web is the repository for the electron app too. |
Ah, ugh, that's confusing. Don't you think two repos (at least for issue reporting) are better, considering that you'll just see such issues as this one being confused. (Or make an issue template, where you ask the user to enter whether this is about the web or Electron version) |
no because then you run into duplication, the amount of electron code in the source vs the rest is a measly couple of %, 99% of issues are not specific to the electron app, as the electron app merely wraps riot-web |
Aha okay, only reported suggestions. Good… So maybe just clarify that stuff in the Readme, then. |
Agreed that the readme should be explicit, in hindsight the package should be |
Can't you create meta packages or so that still refer the old package name? (Don't know anything about that stuff, but have heard that such a thing is possible.) |
Yes, the usual way in Debian of renaming packages while still retaining upgrades is to create a transitional package with the old name that depends on the new name. By the way, the issue for properly naming the desktop package is #3012 |
@uhoreg am I right that it would mean that |
Yes, you wouldn't want to re-use the riot-web package name -- at least not until you're sure that everyone has migrated. e.g. in Debian, you would keep the transitional package for one release of Debian, and then I think in the next release, you could use the package name for something else. In Riot's case, maybe waiting a year would suffice. For the web packaging, you could use the name riot-webapp or something like that. If someone can figure out how to convince electron-builder to build a package with the right name, then creating a transitional package isn't that hard -- you should be able to do it easily using the equivs package. |
I tried building from source for arm64 on an arm64 machine and it failed. From what I understood, one should not build on arm64 machines, but rather cross-build.
And I get the package riot-web_1.1.2_arm64.deb, which installs fine, but only shows empty window when launched on the aarch64 machine. Here are the build log and stderr. |
I tried building using the electronuserland/builder docker image, and it worked!
And here is the package: riot-web_1.1.2_arm64.deb |
Thank you for the instructions in your script MD. I could not build on a armhf device so I cross compiled following your example and it seems to work. riot-web_1.5.13_armv7l.deb |
Still interest for a working "client" on ARM/raspbian. Especially because both firefox and chromium packages on raspbian are too old to use the webclient (well with chromium it sorta works, but I'd prefer something more solid). |
Alright all, I want an ARM build in the riot repo as well, but I think this issue needs to be closed. For a few reasons:
For those curious, here's what I used to build
The weird part of this build command is the
I chose version 1.9.3 because it seems that's what electron-builder was using by default. I attempted to use the latest (1.11?) for my version of ruby but then ran into dpkg errors later because of xz compression. To be honest, I'm not versed enough in any of these tools to really say why. From that it should output a deb file in the Anyways, it took me some time to get this far, so I hope this helps someone. I wouldn't know where to put these instructions otherwise, but aside from the FPM issue everything is very straightforward and easy. @uhoreg all this said is there a good spot for these docs / instructions, and can we close this issue / move it to the |
Organisation/repo admins can move an issue to a different repo on GitHub, so that should be done IMHO. |
riot-desktop issues are tracked in this repo for deduplication. |
@ThatGeoGuy I followed your instructions but building for arm64 failed on |
Indeed, it appears that My workaround was just to symlink |
That worked, thank you! |
could it be possible to get an arm64 package? for Pinebook, Pinephone and Pinetab for example... |
The only matrix-client supporting E2E that can be installed on arm is Nheko so far. sudo apt install nheko . |
Actually Mirage works very well on arm64 and has E2EE: https://github.com/mirukana/mirage, and this has also been packaged for debian as matrix-mirage |
Thank you for this information |
Well, actually Nheko crashes as soon as I enter my id @xxx:xxx . |
Mirage is now in the mobian repo : mirukana/mirage#108 |
Hmm, 3+ years after this issue has been created there are still no |
Ttry as I might, I cannot reproduce your successful build @mdimura with your script I end up at the end missing the electron-builder inside the .bin dir |
Closing in favour of element-hq/element-desktop#650 |
Your Debian package is not available for ARM devices, but considering this are only static files, which Riot consists of, so you could easily also provide it for these devices AFAIK.
The text was updated successfully, but these errors were encountered: