Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pills break if the username is too long #6023

Closed
turt2live opened this issue Jan 23, 2018 · 3 comments
Closed

Pills break if the username is too long #6023

turt2live opened this issue Jan 23, 2018 · 3 comments
Labels
A-Pills P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect X-Needs-Design

Comments

@turt2live
Copy link
Member

Description

image

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 63
  • OS: Windows 10
  • URL: riot.im/develop
@uhoreg
Copy link
Member

uhoreg commented Jan 25, 2018

related to element-hq/element-meta#2644

@lampholder lampholder added T-Defect P1 P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users design and removed 001 mistake label P1 labels Jan 31, 2018
@lampholder
Copy link
Member

In element-hq/element-meta#2644 I said that I thought that a pill any longer than 35 characters looked unappealing.

Unfortunately, if we're going to make room for a disambiguation component, that could easily take ~20 characters by itself without even a particularly long mxid.

The optimal solution to this probably requires a bit of thought. How hard is it just to make pills "work" over multiple lines? It's not ideal, but it would feel less obviously broken (and crucially wouldn't see us creating even more problems as truncating pills interferes with disambiguation).

@turt2live turt2live mentioned this issue Feb 24, 2019
Closed
@jryans jryans added the A-Pills label Jun 23, 2020
@daniellekirkwood daniellekirkwood mentioned this issue Feb 22, 2023
Closed
12 tasks
@weeman1337
Copy link
Contributor

Cannot reproduce any more. Pills are truncated now:

image

@weeman1337 weeman1337 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Pills P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jryans @uhoreg @turt2live @lampholder @weeman1337