-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room appears unread when receiving hidden events - RR not sent #4947
Comments
The solution here is to only indicate new events when said events that are visible in the timeline. If there are none of these, don't make the room tile bold or show unread events. |
This will be inherently fixed by FTUE Notifications which changes how unread state works |
This is still an issue, and an issue on mobile as per element-hq/element-android#5351 I'm not sure what "inherently fixed by FTUE notifications" means, but if it's been nearly two years since that plan and five with this issue being present, maybe a temporary shorter term solution should be implemented? |
I think this is a duplicate of #10954 . Please reopen if it's not. |
To reproduce (with difficulty), the following steps can be taken:
a. not active (i.e. no visible events being added);
b. hasn't been swapped to since the app was refreshed (i.e. hasn't been paginated, has few events in memory and those events are not being shown).
The problem is that the RR (Read Receipt) is not being sent for the room because the only events that would normally qualify are hidden. This is fine for RRs in general and reflects accurately what is happening in a room and who can see what events.
The assumption being made is the following: If the RR is not pointing to an event in memory, this room can be considered unread.
This assumption if broken when all events in memory are hidden events.
The text was updated successfully, but these errors were encountered: