Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot /join an auto-completed room alias #4676

Closed
kegsay opened this issue Jul 25, 2017 · 3 comments · Fixed by matrix-org/matrix-react-sdk#1254
Closed

Cannot /join an auto-completed room alias #4676

kegsay opened this issue Jul 25, 2017 · 3 comments · Fixed by matrix-org/matrix-react-sdk#1254

Comments

@kegsay
Copy link
Contributor

kegsay commented Jul 25, 2017

I tried typing:

/join #neb

and saw #neb:matrix.org pop up, so I selected it with my mouse and then hit enter and a dialog appeared which said:

Command Error
Usage: /join #alias:domain

I'm guessing because the raw text is in markdown form by that point.

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jul 25, 2017

This would be fixed if we didn't insert MD on completion of rooms, much like #4674

The issue is that the draft-js-export-html will convert LINK entities to anchor elements for us, but currently the markdown conversion doesn't consider LINK entities at all. We can change it so that it converts LINKs to [links](some.url) before saving to history and sending the message.

@lukebarnard1
Copy link
Contributor

because the raw text is in markdown form by that point.

correct

This was referenced Jul 25, 2017
@lukebarnard1
Copy link
Contributor

So instead of totally rewriting the RTE to either use entities with type MENTION or totally rewriting the RTE to always use the same AST for a given message (see #4679), I'm going to do the quick fix of stripping MD mentions before handling commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants