Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When autoplaying videos, don't autoplay until they are in view #4528

Open
turt2live opened this issue Jul 6, 2017 · 7 comments
Open

When autoplaying videos, don't autoplay until they are in view #4528

turt2live opened this issue Jul 6, 2017 · 7 comments

Comments

@turt2live
Copy link
Member

turt2live commented Jul 6, 2017

Bountysource

Description

Videos that are out of view but still in the loaded timeline should only autoplay once they are visible by the user, not right away. You will need the autoplay option enabled to reproduce this.

Log: not sent

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 58
  • OS: Windows 10
  • URL: riot.im/develop
@turt2live
Copy link
Member Author

Further, pause them when they have been scrolled out of view so that they can continue playing when you scroll them back into view.

@turt2live
Copy link
Member Author

Updated original post for the bounty :)

@IJustDev
Copy link

IJustDev commented May 2, 2020

Is this still up to date?

@turt2live
Copy link
Member Author

yes, though the bounty image is broken and tbh I don't plan on fixing that.

@IJustDev
Copy link

IJustDev commented May 5, 2020

I'm currently working on it. I hope I will soon be able to create a pull request.

This issue should be moved to matrix-react-sdk. Shouldn't it?

@t3chguy
Copy link
Member

t3chguy commented May 5, 2020

react-sdk doesn't have issues enabled so no

@IJustDev
Copy link

IJustDev commented May 8, 2020

I created following commit. Even though it fixes the bug, it's a very ugly workaround and I will come up with a better solution in a short period of time.

IJustDev/matrix-react-sdk@ef49168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants