Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on develop: missing translations in login screen #4115

Closed
uhoreg opened this issue May 31, 2017 · 8 comments
Closed

on develop: missing translations in login screen #4115

uhoreg opened this issue May 31, 2017 · 8 comments

Comments

@uhoreg
Copy link
Member

uhoreg commented May 31, 2017

image

@uhoreg
Copy link
Member Author

uhoreg commented May 31, 2017

(hope you don't mind me marking this as a blocker)

@lampholder
Copy link
Member

Heh, this is a fairly prominent instance, I think release-blocker is highly appropriate :P

@uhoreg
Copy link
Member Author

uhoreg commented Jun 1, 2017

This is fixed in /staging, so closing

@uhoreg uhoreg closed this as completed Jun 1, 2017
@ara4n
Copy link
Member

ara4n commented Jun 1, 2017

i wonder if this was a stale cache of i18n/*.json....

@uhoreg
Copy link
Member Author

uhoreg commented Jun 1, 2017

Actually, it's still present on /develop, but since it isn't present on /app, then presumably it's an issue with the build process, rather than the code itself -- like a stale cache as @ara4n said. So reopening, but removing the release-blocker tag.

@uhoreg uhoreg reopened this Jun 1, 2017
@ara4n
Copy link
Member

ara4n commented Jun 1, 2017

does it go away if you force-clear your browser cache? if you curl the i18n json in question, what are the expire headers on it?

@uhoreg
Copy link
Member Author

uhoreg commented Jun 1, 2017

Oh, you were talking about browser cache. Yes, when I shift-reload, then the problem goes away. The expire header is "Thu, 01 Jun 2017 02:35:14 GMT", which is 1 day. Should the i18n files be stuck somehow inside the /bundles/[hash]/ directory along with the js and css files so that it won't load stale files?

@ara4n
Copy link
Member

ara4n commented Jun 1, 2017

closed in favour of #4136

@ara4n ara4n closed this as completed Jun 1, 2017
@jryans jryans added I18n and removed A-I18n labels Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants