-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on develop: missing translations in login screen #4115
Comments
(hope you don't mind me marking this as a blocker) |
Heh, this is a fairly prominent instance, I think release-blocker is highly appropriate :P |
This is fixed in /staging, so closing |
i wonder if this was a stale cache of i18n/*.json.... |
Actually, it's still present on /develop, but since it isn't present on /app, then presumably it's an issue with the build process, rather than the code itself -- like a stale cache as @ara4n said. So reopening, but removing the release-blocker tag. |
does it go away if you force-clear your browser cache? if you curl the i18n json in question, what are the expire headers on it? |
Oh, you were talking about browser cache. Yes, when I shift-reload, then the problem goes away. The expire header is "Thu, 01 Jun 2017 02:35:14 GMT", which is 1 day. Should the i18n files be stuck somehow inside the |
closed in favour of #4136 |
The text was updated successfully, but these errors were encountered: