Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend message type in thread panel #27890

Closed
daniellekirkwood opened this issue Aug 1, 2024 · 8 comments · Fixed by #28361
Closed

Prepend message type in thread panel #27890

daniellekirkwood opened this issue Aug 1, 2024 · 8 comments · Fixed by #28361
Assignees
Labels
A-Message-Pinning A-Polls A-Right-Panel A-Stickers A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement T-Feature Request to add a new feature which does not exist right now Z-Labs

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Aug 1, 2024

Your use case

What would you like to do?

In the Thread list panel there's no details about the type of message that the thread root is. This is quite confusing.

Screenshot 2024-08-01 at 16 27 36

The first message in this list is a poll and the third is a sticker.

Why would you like to do it?

Make the product better

How would you like to achieve it?

Prepend the event with the event type where the rendering has to change

eg:
Screenshot 2024-08-01 at 16 29 06

We do this in the room list for message previews and now with pinned messages

Have you considered any alternatives?

No response

Additional context

No response

@dosubot dosubot bot added A-Polls A-Stickers O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Feature Request to add a new feature which does not exist right now labels Aug 1, 2024
@t3chguy
Copy link
Member

t3chguy commented Aug 1, 2024

We do this in the room list for message previews

I can't reproduce that

image

Do designs for this exist wrt font and all the available copy options for the many types of event?

@dbkr dbkr added the S-Tolerable Low/no impact on users label Aug 5, 2024
@daniellekirkwood
Copy link
Contributor Author

Screenshot 2024-08-05 at 12 30 20

@daniellekirkwood
Copy link
Contributor Author

@americanrefugee would you be able to mock up a screen or two of what i'm describing here? Do you agree that it's a direction we'd want to go?

@daniellekirkwood
Copy link
Contributor Author

@daniellekirkwood
Copy link
Contributor Author

daniellekirkwood commented Oct 15, 2024

@t3chguy I would like to make it clearer to users the type of message that appears in the right panel (if it's not immediately obvious). This could also apply to the room list too (right now we have an icon for a thread message but nothing else).

In the pinned message banner, we do prepend the message with the type where type != message.

Would you help me by describing what someone might need in order to make this issue ready to be worked on? I can then pull that info together in the description.

(tagging you because it's currently part of the room header & right panel work) :)

EG:
Screenshot 2024-10-15 at 15 08 39

@t3chguy
Copy link
Member

t3chguy commented Oct 16, 2024

If it already exists for Pinned messages then we can probably just say to copy that

@t3chguy
Copy link
Member

t3chguy commented Nov 1, 2024

@daniellekirkwood do we want the same prefix for thread replies too?

image
image

e.g. if Testing was the name of a file should it be *File*: Testing

@daniellekirkwood
Copy link
Contributor Author

I think that might be overkill but yes, let's lean into it and see if there's any responses? I'd rather be clear than confusing... especially given the number of accessibility reports we get about confusing content... 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Message-Pinning A-Polls A-Right-Panel A-Stickers A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement T-Feature Request to add a new feature which does not exist right now Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants