Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image view is broken #27175

Closed
robintown opened this issue Mar 13, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12341
Closed

Image view is broken #27175

robintown opened this issue Mar 13, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12341
Assignees
@robintown
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Upcoming-Release-Blocker This does not affect the current release cycle but will affect the next one

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Open an image

Outcome

What did you expect?

All UI elements should be within view

What happened instead?

Screenshot 2024-03-13 at 11-27-55 Element Element Web Internal

This is a regression due to matrix-org/matrix-react-sdk#12332

Operating system

NixOS unstable

Browser information

Firefox 122.0.1

URL for webapp

develop.element.io

Application version

Element version: 54ba087-react-80c4c3c28c21-js-78d05942a35a Crypto version: Rust SDK 0.7.0 (b1918e9), Vodozemac 0.5.1

Homeserver

Not relevant

Will you send logs?

No
@robintown robintown added T-Defect X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Release-Blocker O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Mar 13, 2024
@robintown robintown self-assigned this Mar 13, 2024
This was referenced Mar 14, 2024
Closed
Closed
@MTRNord
Copy link
Contributor

MTRNord commented Mar 14, 2024

Also the images have hard corners while the dialog has rounded corners which causes the corners to go outside the dialog despite consistent padding all around.

@robintown robintown mentioned this issue Mar 14, 2024
Merged
@t3chguy t3chguy added X-Upcoming-Release-Blocker This does not affect the current release cycle but will affect the next one and removed X-Release-Blocker labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robintown robintown

Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Upcoming-Release-Blocker This does not affect the current release cycle but will affect the next one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the image view robintown/matrix-react-sdk
3 participants
@MTRNord @t3chguy @robintown