Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggles, radios and checkboxes in Element settings don't render properly when turned on #27166

Closed
bblacher opened this issue Mar 12, 2024 · 10 comments

Comments

@bblacher
Copy link

bblacher commented Mar 12, 2024

Steps to reproduce

Open settings while using dark theme

Outcome

image

Operating system

Arch Linux rolling

Application version

Element version: 1.11.60 Crypto version: Rust SDK 0.7.0 (b1918e9), Vodozemac 0.5.1

How did you install the app?

https://archlinux.org/packages/extra/x86_64/element-desktop/ (modified PKGBUILD to use electron 29 and newest Element version)

Homeserver

Synapse 1.102.0

Will you send logs?

No

@wrenix
Copy link

wrenix commented Mar 12, 2024

Also on

  1. light mode
  2. radio and checkbox (like on theming for light and dark mode)

@bblacher
Copy link
Author

Screenshots showing the problem on light theme:
image

Missing checkbox:
image

@bblacher bblacher changed the title Toggles in Element settings don't render properly when turned while using dark mode Toggles in Element settings don't render properly when turned on while using dark mode Mar 12, 2024
@bblacher bblacher changed the title Toggles in Element settings don't render properly when turned on while using dark mode Toggles in Element settings don't render properly when turned on Mar 12, 2024
@wrenix
Copy link

wrenix commented Mar 12, 2024

@florianduros
Copy link
Member

@wrenix It's working correctly.

Following my analysis, the bug is only on the built version of the desktop app.

@florianduros
Copy link
Member

florianduros commented Mar 13, 2024

We are missing in the build some compound variables like: --cpd-color-bg-accent-rest

@mokazemi
Copy link

@wrenix It's working correctly.

Following my analysis, the bug is only on the built version of the desktop app.

No. I'm so experiencing it on the web version.

@t3chguy
Copy link
Member

t3chguy commented Mar 13, 2024

@florianduros I can repro on app & staging

image
image

@t3chguy t3chguy changed the title Toggles in Element settings don't render properly when turned on Toggles and radios in Element settings don't render properly when turned on Mar 13, 2024
@bblacher bblacher changed the title Toggles and radios in Element settings don't render properly when turned on Toggles, radios and checkboxes in Element settings don't render properly when turned on Mar 14, 2024
@florianduros
Copy link
Member

@t3chguy Yep I saw it in the evening. I'm trying to update all the old design-tokens reference to fix it.

@florianduros
Copy link
Member

Should be fixed in the next release.

@wrenix
Copy link

wrenix commented Mar 14, 2024

works, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants