Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element Web and Desktop both appear to have lost their "OIDC-awareness" with respect to account management #26638

Closed
hughns opened this issue Nov 24, 2023 · 7 comments · Fixed by matrix-org/matrix-react-sdk#12144
Assignees
Labels
A-OIDC O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Labs

Comments

@hughns
Copy link
Member

hughns commented Nov 24, 2023

Things that I have noticed no longer work:

image

I suspect something is broken in the discovery part. I'll have a quick look myself to see if anything obvious.

@t3chguy
Copy link
Member

t3chguy commented Nov 24, 2023

image
image

It looks like it uses session storage so forgets it was an OIDC session when you close the tab possibly

@hughns
Copy link
Member Author

hughns commented Nov 24, 2023

I'm seeing it immediately after a fresh login.

I think the issue was introduced by matrix-org/matrix-react-sdk#11723. The new implementation from the PR only works with a OIDC-native sessions, whereas we want the implementation to work with both OIDC-native and OIDC-aware sessions.

@Johennes Johennes added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Labs A-OIDC labels Nov 24, 2023
@t3chguy t3chguy self-assigned this Jan 15, 2024
@t3chguy
Copy link
Member

t3chguy commented Jan 15, 2024

Looks like it - regressed by matrix-org/matrix-react-sdk#11723

@langleyd
Copy link
Member

langleyd commented Feb 9, 2024

This still looks broken to @pmaier1 and myself. @t3chguy mind taking a a look?

@langleyd langleyd reopened this Feb 9, 2024
@t3chguy
Copy link
Member

t3chguy commented Feb 9, 2024

You'll need to sign in again, can't bring back forgotten data

@t3chguy
Copy link
Member

t3chguy commented Feb 9, 2024

@pmaier1 please open a new issue with repro steps and logs on a version containing the fix

@t3chguy t3chguy closed this as completed Feb 9, 2024
@langleyd
Copy link
Member

I have opened #26997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-OIDC O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants