Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customizable email branding during signup & password reset #2655

Closed
ghost opened this issue Nov 26, 2016 · 3 comments
Closed

Support customizable email branding during signup & password reset #2655

ghost opened this issue Nov 26, 2016 · 3 comments
Labels
A-Registration A-UI-Customisation UIFeatures etc. for customising entire parts of the UI P2 T-Enhancement

Comments

@ghost
Copy link

ghost commented Nov 26, 2016

Hello

I started the server with python -m sydent.sydent - everything seems to work but there is no info how I should configure web client or Android app to use the identity server.

Currently synapse gives this error:

2016-11-27 16:57:30,814 - synapse.http.server - 139 - ERROR - POST-53- Failed handle request synapse.http.server._async_render on <synapse.rest.ClientRestResource object at 0x7f5694cc1f90>: <SynapseRequest at 0x7f568ddf1518 method=POST uri=/_matrix/client/r0/account/3pid/email/requestToken clientproto=HTTP/1.1 site=8448>
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/synapse/http/server.py", line 116, in wrapped_request_handler
    yield request_handler(self, request, request_metrics)
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/usr/lib/python2.7/dist-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/usr/lib/python2.7/dist-packages/synapse/http/server.py", line 255, in _async_render
    callback_return = yield callback(request, **kwargs)
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/usr/lib/python2.7/dist-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/usr/lib/python2.7/dist-packages/synapse/rest/client/v2_alpha/account.py", line 195, in on_POST
    ret = yield self.identity_handler.requestEmailToken(**body)
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1126, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/usr/lib/python2.7/dist-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/usr/lib/python2.7/dist-packages/synapse/handlers/identity.py", line 158, in requestEmailToken
    params
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1128, in _inlineCallbacks
    result = g.send(result)
  File "/usr/lib/python2.7/dist-packages/synapse/http/client.py", line 128, in post_urlencoded_get_json
    defer.returnValue(json.loads(body))
  File "/usr/lib/python2.7/dist-packages/simplejson/__init__.py", line 505, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/dist-packages/simplejson/decoder.py", line 370, in decode
    obj, end = self.raw_decode(s)
  File "/usr/lib/python2.7/dist-packages/simplejson/decoder.py", line 400, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
JSONDecodeError: Expecting value: line 2 column 1 (char 1)

Should I specify port (8090) too or will the server detect itself? If the port is specified in web client then it starts to spin but there is no response nor anything interesting in the logs. Really no idea what I'm missing here..

Thanks

@ghost ghost changed the title customizable email (Sydent problem) customizable email Nov 26, 2016
@ara4n
Copy link
Member

ara4n commented Dec 18, 2016

The right place for sydent bugs is the sydent repo at matrix-org/sydent.

That said, running your own sydent is almost always the Wrong Answer, as you are then isolated from the rest of Matrix.

The actual solution to what you want here is probably matrix-org/synapse#1710, which would let your HS brand the emails correctly. Turning this bug into a tracker for supporting branded email validation.

@ara4n ara4n changed the title (Sydent problem) customizable email Support customizable email branding during signup & password reset Dec 18, 2016
@ara4n
Copy link
Member

ara4n commented Dec 18, 2016

Another solution would be to allow us to pass basic branding template info to the IS from the HS during the signup dance.

@kittykat kittykat added the A-UI-Customisation UIFeatures etc. for customising entire parts of the UI label Aug 24, 2021
@kittykat
Copy link
Contributor

Closing as the synapse issue is now resolved (see matrix-org/synapse#1710 for more information)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Registration A-UI-Customisation UIFeatures etc. for customising entire parts of the UI P2 T-Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants