Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space pills inconsistent/broken layout #26056

Closed
HarHarLinks opened this issue Aug 25, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#11632
Closed

Space pills inconsistent/broken layout #26056

HarHarLinks opened this issue Aug 25, 2023 · 4 comments · Fixed by matrix-org/matrix-react-sdk#11632
Assignees
Labels
A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@HarHarLinks
Copy link
Contributor

HarHarLinks commented Aug 25, 2023

Steps to reproduce

  1. send a space pill

Outcome

What did you expect?

  • square space icon looks proper in rounded pill
  • icon is vertically centered
  • composer behaves the same as timeline

What happened instead?

  • square space icon looks strange as the pill around it is completely round, it looks like it doesn't properly fit in there
  • slight offset towards the bottom of the pill
  • composer uses round avatar for space in pill when it should be square
    image

Operating system

arch

Application version

Element Nightly version: 2023082401 Olm version: 3.2.14

How did you install the app?

aur

Homeserver

No response

Will you send logs?

No

@HarHarLinks
Copy link
Contributor Author

somewhat related to #26046

@germain-gg
Copy link
Contributor

germain-gg commented Aug 29, 2023

This was an unexpected change, but does actually uses the correct semantic for space avatars that have square corners.

Follows up on the conversation in https://matrix.to/#/!zzGPdcyFqxIOJEijoI:matrix.org/$8lFyjiAabtD4Br-tbYRqb5c3QT347X9smBAaGddNfYU?via=matrix.org&via=element.io&via=envs.net

Raising this with @nadonomy and @americanrefugee

@germain-gg germain-gg added A-Avatar S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 29, 2023
@HarHarLinks
Copy link
Contributor Author

i kinda wish the pill was just rounded-square shaped on the left for spaces, but with a bit more padding than
image

@Johennes
Copy link
Contributor

Johennes commented Sep 11, 2023

Chatted about this with @nadonomy and @janogarcia this morning. The desired solution is to keep the avatar in space pills rounded rect but have the pill itself be rounded rect on the left side, too.

111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants