Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget menu not visible if a user has no permissions to edit widgets #24826

Closed
weeman1337 opened this issue Mar 15, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#11257
Closed

Widget menu not visible if a user has no permissions to edit widgets #24826

weeman1337 opened this issue Mar 15, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#11257
Assignees
@t3chguy
Labels
A-Power-Levels The permissions that users have in rooms and spaces A-Widgets O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@weeman1337
Copy link
Contributor

weeman1337 commented Mar 15, 2023 •
edited
Loading

Steps to reproduce

  1. Create a room as user A,
  2. Invite user B
  3. Add a jitsi widget to a room
  4. As user B click the three dots in the widget title

Outcome

What did you expect?

The menu should show up with the options available (for instance „revoke permissions“).

What happened instead?

The menu does not show up.

widget

Operating system

Ubuntu 22.04.2 LTS

Browser information

Chromium Version 110.0.5481.177 (Official Build) (64-bit)

URL for webapp

https://develop.element.io/

Application version

Version von Element: 4a18ab6-react-0c38bd7bebf9-js-7faba5c2f0bb Version von Olm: 3.2.12

Homeserver

No response

Will you send logs?

No
@t3chguy

This comment was marked as outdated.

Sign in to view
@t3chguy

This comment was marked as outdated.

Sign in to view
@weeman1337 weeman1337 changed the title Widget menu broken on Chromium-based browsers (and desktop app) Widget menu visible if a user has no permissions to edit widgets Mar 15, 2023
@weeman1337
Copy link
Contributor Author

@t3chguy thanks for testing this. I found the actual problem and updated the title and description accordingly.

@t3chguy
Copy link
Member

t3chguy commented Mar 15, 2023

@weeman1337 do you mean not visible?

@weeman1337 weeman1337 changed the title Widget menu visible if a user has no permissions to edit widgets Widget menu trigger visible if a user has no permissions to edit widgets Mar 15, 2023
@weeman1337
Copy link
Contributor Author

Two options: Menu not visible or menu trigger visible 🤷‍♂️
I've updated the issue again.

@t3chguy
Copy link
Member

t3chguy commented Mar 15, 2023

The trigger isn't exclusive for admins, the Revoke permissions option lives there

@weeman1337 weeman1337 changed the title Widget menu trigger visible if a user has no permissions to edit widgets Widget menu not visible if a user has no permissions to edit widgets Mar 15, 2023
@robintown robintown added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Widgets O-Occasional Affects or can be seen by some users regularly or most users rarely A-Power-Levels The permissions that users have in rooms and spaces S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Mar 22, 2023
@t3chguy t3chguy mentioned this issue Jul 13, 2023
Merged
@t3chguy t3chguy self-assigned this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Power-Levels The permissions that users have in rooms and spaces A-Widgets O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide widget menu button if it there are no options available matrix-org/matrix-react-sdk
3 participants
@t3chguy @weeman1337 @robintown