Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages stuck or very slow at "Encrypting your message..." #24153

Closed
germain-gg opened this issue Jan 4, 2023 · 12 comments
Closed

Messages stuck or very slow at "Encrypting your message..." #24153

germain-gg opened this issue Jan 4, 2023 · 12 comments
Labels
A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@germain-gg
Copy link
Contributor

Steps to reproduce

  1. Send a message

Outcome

What did you expect?

The message to send instantanously

What happened instead?

It's very slow, above the 2mn mark!
Screenshot 2023-01-04 at 10 23 10

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

Yes

@germain-gg germain-gg added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 4, 2023
@t3chguy
Copy link
Member

t3chguy commented Jan 4, 2023

Duplicate of #16043

@t3chguy t3chguy marked this as a duplicate of #16043 Jan 4, 2023
@t3chguy t3chguy closed this as completed Jan 4, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2023
@germain-gg germain-gg reopened this Jan 4, 2023
@germain-gg
Copy link
Contributor Author

Not a duplicate, this has just happened in a room with 20 people. I would not consider this a "massive" room.

@germain-gg germain-gg changed the title Messages takes a long time to encrypt Messages take a long time to encrypt Jan 9, 2023
@germain-gg
Copy link
Contributor Author

Adding X-Regression this was not happening a month ago!

@clokep
Copy link

clokep commented Jan 9, 2023

I've also seen this happen in fairly small rooms. Although mine wasn't quite as small (57 and 103 users). Maybe someone has a lot of devices though?

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Jan 19, 2023

I encountered this today morning.

  • I was sending one message to Element Web Internal (27 people)
  • I also was sending a few messages in a DM to @clokep
  • One message to a room with 3 people (pressed Enter at 11:10am > Message still not sent at 11:15)

I was able to send messages instantly on iOS, on web these 2 rooms took around 5 minutes to send - they stayed looking like the screenshot above.

I upgraded my version using the pop up tile in the top left
this morning before sending any messages.

I'm using Nightly: Element Nightly version: 2023011701 | Olm version: 3.2.12

Sent a rageshake

@germain-gg
Copy link
Contributor Author

I've seen a few ad hoc mention of this issue in multiple internal rooms. Will bump to O-Frequent as it's been experienced many times by many different people

@germain-gg germain-gg added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 19, 2023
@ara4n
Copy link
Member

ara4n commented Jan 23, 2023

Maybe someone has a lot of devices though?

This is "only" 1276 devices. I've benchmarked it in Oct v Jan based on rageshakes for the same number of devices (43 slices, so 1075 in total) and it looks like we have a ~50% slowdown from somewhere. It also really feels like it's churning megolm more frequently than I'd expect, and/or not setting them up proactively enough.

@davidegirardi
Copy link

davidegirardi commented Feb 14, 2023

I got this in multiple rooms today, not in DMs for some reason.

I checked the console log in one room where I had 3 "stuck" messages and I found three of these:

rageshake.ts:73 Event ~!EVENTIDHERE in room !ROOMIDHERE is live, but it does not have a timeline
e.<computed> @ rageshake.ts:73

See the rageshake for the event information. At the time of writing they have been stuck for about 2 hours.

I could receive other people's messages just fine.

EDIT: restarting Element Desktop just removed the messages without sending them.

@germain-gg germain-gg changed the title Messages take a long time to encrypt Messages stuck or very slow at "Encrypting your message..." Feb 14, 2023
@richvdh
Copy link
Member

richvdh commented Feb 14, 2023

I did a deep dive on one instance of a slow send at https://github.com/matrix-org/element-web-rageshakes/issues/20102; my conclusion is:

  • it takes 80 seconds to send keys out in a room with 1288 devices (~60ms per device).
  • There might be room to optimise it, but since we're replacing the offending code as part of Adopt the E2EE cryptography module from matrix-rust-sdk: "Element R" #21972 I'm not sure that is a good use of time.
  • I see no evidence of this being a regression, though if someone can point me to logs from October or earlier I can compare.

(If messages are actually getting stuck for periods of several minutes, that sounds like a different problem.)

@davidegirardi
Copy link

FYI I attached a (different) rageshake to #15476 too as it seems the closest to my situation.

@richvdh
Copy link
Member

richvdh commented Feb 14, 2023

Duplicate of #15476.

@richvdh
Copy link
Member

richvdh commented Feb 22, 2023

(If messages are actually getting stuck for periods of several minutes, that sounds like a different problem.)

Have opened #24612 to track this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

7 participants