Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MXIDs with forward slashes not recognised #23708

Closed
0x1a8510f2 opened this issue Nov 4, 2022 · 8 comments
Closed

MXIDs with forward slashes not recognised #23708

0x1a8510f2 opened this issue Nov 4, 2022 · 8 comments
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@0x1a8510f2
Copy link

0x1a8510f2 commented Nov 4, 2022 •
edited
Loading

Related: matrix-org/matrix.to#288

Steps to reproduce

  1. Send an MXID without a slash in chat
  2. Notice that it automatically gets linkified with the correct matrix.to link
  3. Send an MXID with forward slash in chat
  4. Notice that it does not get linkified correctly

Outcome

What did you expect?

Per the spec, the MXID should be recognised.

What happened instead?

image

Operating system

(not relevant)

Browser information

(not relevant)

URL for webapp

(not relevant)

Application version

1.11.12

Homeserver

(not relevant)

Will you send logs?

No
@andybalaam andybalaam added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Nov 7, 2022
@t3chguy
Copy link
Member

t3chguy commented Nov 14, 2022

Related #6381

@0x1a8510f2
Copy link
Author

0x1a8510f2 commented Nov 14, 2022 •
edited
Loading

Going through the comments on the linked issue, it looks like there are a few related issues actually, mostly from 5 years back:

#6381
#4867
#5135

Not sure if I should close this as duplicate then?

In either case, any chances this could get some priority? It's impossible to work around if you have a nickname with a slash in it and seems to have been around for a while.

@Johennes
Copy link
Contributor

I cannot reproduce this on current nightly. It might have been fixed with matrix-org/matrix-react-sdk#11132.

Screenshot 2023-06-28 at 19 50 24

@t3chguy
Copy link
Member

t3chguy commented Jun 29, 2023

@Johennes one interesting tidbit, they get handled differently.

image

Only the latter gets a URL preview

@Johennes
Copy link
Contributor

Oh interesting. None of them should get one, right?

@t3chguy
Copy link
Member

t3chguy commented Jun 29, 2023

Indeed

@t3chguy
Copy link
Member

t3chguy commented Jun 29, 2023

image

@t3chguy t3chguy mentioned this issue Jun 29, 2023
Merged
@Johennes
Copy link
Contributor

Ohh, nice find! And thanks for fixing it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andybalaam @Johennes @t3chguy @0x1a8510f2