Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume control doesn't work on E2E notifications #2342

Closed
aviraldg opened this issue Sep 23, 2016 · 7 comments
Closed

Volume control doesn't work on E2E notifications #2342

aviraldg opened this issue Sep 23, 2016 · 7 comments
Labels
A-E2EE A-Notifications P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Community-Testing

Comments

@aviraldg
Copy link
Contributor

Erik says so. Manifests as notifications showing up for e2e rooms even if they're turned off from settings
@ara4n ara4n added T-Defect P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-E2EE A-Notifications labels Oct 10, 2016
@ara4n ara4n changed the title Default notification rules do not override those of e2e Volume control doesn't work on E2E notifications Oct 10, 2016
@ara4n
Copy link
Member

ara4n commented Jan 9, 2019

see also #6745

@ara4n
Copy link
Member

ara4n commented Jan 9, 2019

see also #2256

@jryans
Copy link
Collaborator

jryans commented Jan 9, 2019 •
edited
Loading

I added separate global volume controls to Settings for encrypted messages in matrix-org/matrix-react-sdk#2346. Maybe that's enough to mark this as fixed then?

@ara4n
Copy link
Member

ara4n commented Jan 9, 2019

hm, that doesn't affect it ignoring the specified muteness/noisiness on the room, though, does it?

@jryans
Copy link
Collaborator

jryans commented Jan 9, 2019

Here's what I get when using the "Encrypted messages in group chats" global control in Settings combined with the per-room volume control for an E2E room:

  Global: Off Global: On Global: Noisy
Room: Mute 🤫 🤫 🤫
Room: All Messages 🤫 ✉️ 🔔
Room: Noisy 🔔 🔔 🔔

🤫 = nothing happens
✉️ = silent notification
🔔 = noisy notification

@jryans
Copy link
Collaborator

jryans commented Jan 10, 2019

@ara4n Does the table above match the desired state here? If so, then it seems fixed.

@kittykat
Copy link
Contributor

kittykat commented Dec 1, 2021

I'm going to close this issue for now as the issue seems to be resolved, please file a new one if any further changes are needed.

@kittykat kittykat closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-Notifications P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Community-Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @aviraldg @jryans @ara4n