Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some slash-commands like /myroomnick not working in „pre-DM“ #23082

Open
weeman1337 opened this issue Aug 16, 2022 · 7 comments
Open

Some slash-commands like /myroomnick not working in „pre-DM“ #23082

weeman1337 opened this issue Aug 16, 2022 · 7 comments
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@weeman1337
Copy link
Contributor

Steps to reproduce

  1. Start a DM with someone, do not send the first message
  2. Run a slash-command like /myroomnick

Other commands are also affected.

Outcome

What did you expect?

Some commands could be executed on room creation. For instance /myroomnick totally makes sense.

Others should not be available. Example for that would be /addwidget.

What happened instead?

Server error - unknown room

Operating system

Ubuntu 22.04.1 LTS

Browser information

Firefox 103.0.2

URL for webapp

https://develop.element.io/

Application version

Element version: 39eee10-react-0dffc582e7e5-js-3f6f5b69c7a1 Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

No

@Mikaela
Copy link
Contributor

Mikaela commented Aug 16, 2022

Kind of related at least for the other end: element-hq/element-meta#370

@HarHarLinks
Copy link
Contributor

The issue is that no room exists yet for the command to be executed against. Element would need to locally cache it and when the first message gets sent, execute the cached commands first. Or merge them into the join event instead of sending additional rejoin events.

This is also related to per-space-profiles

@weeman1337
Copy link
Contributor Author

This is about fixing the error for „pre-DM“ rooms. element-hq/element-meta#370 will remain valid.

@t3chguy
Copy link
Member

t3chguy commented Aug 16, 2022

@weeman1337 are we sure this will be considered fixed, a disabled command doesn't show up which might be a confusing UX, feeling broken and unclear as to why some rooms have the command and some others

@weeman1337
Copy link
Contributor Author

Nope - not sure. But on the other hand in the current state some commands end up with „Server Error - Unknown room“.

@t3chguy
Copy link
Member

t3chguy commented Aug 16, 2022

@weeman1337 the PR is definitely an improvement, but a better designed solution may be desirable in the longer term. I do not think this issue will get closed by that PR, because /myroomnick will still not work in pre-DM, it just won't be an autocomplete suggestion either.

@weeman1337
Copy link
Contributor Author

I do not think this issue will get closed by that PR, because /myroomnick will still not work in pre-DM

@t3chguy agree. Changed the PR not to close this issue.

@andybalaam andybalaam added X-Regression S-Tolerable Low/no impact on users O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 17, 2022
@weeman1337 weeman1337 removed their assignment Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

5 participants