-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some slash-commands like /myroomnick not working in „pre-DM“ #23082
Comments
Kind of related at least for the other end: element-hq/element-meta#370 |
The issue is that no room exists yet for the command to be executed against. Element would need to locally cache it and when the first message gets sent, execute the cached commands first. Or merge them into the join event instead of sending additional rejoin events. This is also related to per-space-profiles |
This is about fixing the error for „pre-DM“ rooms. element-hq/element-meta#370 will remain valid. |
@weeman1337 are we sure this will be considered fixed, a disabled command doesn't show up which might be a confusing UX, feeling broken and unclear as to why some rooms have the command and some others |
Nope - not sure. But on the other hand in the current state some commands end up with „Server Error - Unknown room“. |
@weeman1337 the PR is definitely an improvement, but a better designed solution may be desirable in the longer term. I do not think this issue will get closed by that PR, because |
@t3chguy agree. Changed the PR not to close this issue. |
Steps to reproduce
/myroomnick
Other commands are also affected.
Outcome
What did you expect?
Some commands could be executed on room creation. For instance
/myroomnick
totally makes sense.Others should not be available. Example for that would be
/addwidget
.What happened instead?
Server error - unknown room
Operating system
Ubuntu 22.04.1 LTS
Browser information
Firefox 103.0.2
URL for webapp
https://develop.element.io/
Application version
Element version: 39eee10-react-0dffc582e7e5-js-3f6f5b69c7a1 Olm version: 3.2.12
Homeserver
matrix.org
Will you send logs?
No
The text was updated successfully, but these errors were encountered: