Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for selecting which DM to reuse (if any) when finding a conversation with a person #2148

Closed
ara4n opened this issue Sep 9, 2016 · 9 comments

Comments

@ara4n
Copy link
Member

ara4n commented Sep 9, 2016

In #1882 we decided in in the short term to reuse existing DMs when trying to 'start a chat' with a user.

However, this is pretty confusing and magical if you have multiple DMs or rooms in common with a user.

Much as #1477 shows all the rooms you have in common in a MemberInfo to let you pick how to contact someone, we need a design so that having tried to start a chat with someone from the BottomLeftMenu, we can be told "actually, you already have 3 DMs with them - do you want to use one of them rather than starting another?"

I suggest we could just update the 'start chat' dialog box with possible rooms to use for the user who has been specified in the input field, so the user can just click through to those rooms rather than actually hitting the 'start chat' button.

@turt2live
Copy link
Member

@ara4n this seems implemented?
image

@t3chguy
Copy link
Member

t3chguy commented Oct 25, 2017

seems half-done, doesn't seem to get triggered from Start Chat

@t3chguy
Copy link
Member

t3chguy commented Oct 25, 2017

or maybe has regressed, I've seen it in the past

@t3chguy
Copy link
Member

t3chguy commented Jan 4, 2018

I just had it pop up on me so it definitely works at least sometimes

@aaronraimist
Copy link
Collaborator

aaronraimist commented Nov 28, 2018

I think this is done. It always seems to work.

@turt2live
Copy link
Member

I think this is asking for the "Start chat" button on the MemberInfo to also give the same dialog. I think...

@turt2live
Copy link
Member

I also just tried it and it definitely did not prompt.

@aaronraimist
Copy link
Collaborator

Well no the button on MemberInfo doesn't but the rooms are displayed right above the button

screen shot 2018-11-28 at 3 44 06 pm

@turt2live
Copy link
Member

This happens automatically now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants