-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI for selecting which DM to reuse (if any) when finding a conversation with a person #2148
Comments
@ara4n this seems implemented? |
seems half-done, doesn't seem to get triggered from Start Chat |
or maybe has regressed, I've seen it in the past |
I just had it pop up on me so it definitely works at least sometimes |
I think this is done. It always seems to work. |
I think this is asking for the "Start chat" button on the MemberInfo to also give the same dialog. I think... |
I also just tried it and it definitely did not prompt. |
This happens automatically now. |
In #1882 we decided in in the short term to reuse existing DMs when trying to 'start a chat' with a user.
However, this is pretty confusing and magical if you have multiple DMs or rooms in common with a user.
Much as #1477 shows all the rooms you have in common in a MemberInfo to let you pick how to contact someone, we need a design so that having tried to start a chat with someone from the BottomLeftMenu, we can be told "actually, you already have 3 DMs with them - do you want to use one of them rather than starting another?"
I suggest we could just update the 'start chat' dialog box with possible rooms to use for the user who has been specified in the input field, so the user can just click through to those rooms rather than actually hitting the 'start chat' button.
The text was updated successfully, but these errors were encountered: