Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom branch won't build from Docker. #20936

Closed
wiksien opened this issue Feb 5, 2022 · 2 comments
Closed

Custom branch won't build from Docker. #20936

wiksien opened this issue Feb 5, 2022 · 2 comments
Labels

Comments

@wiksien
Copy link

wiksien commented Feb 5, 2022

Steps to reproduce

  1. I do steps exactly as described in README.md section titled Running from Docker up to git checkout command.
  2. I write git checkout develop.
  3. I write modified docker build command so it works on my operating system: docker build -t element-web:local-test --build-arg USE_CUSTOM_SDKS=true --build-arg REACT_SDK_REPO="https://github.com/matrix-org/matrix-react-sdk.git" --build-arg REACT_SDK_BRANCH="develop" --build-arg JS_SDK_REPO="https://github.com/matrix-org/matrix-js-sdk.git" --build-arg JS_SDK_BRANCH="develop" .
    docker build -t element-web:local-test \
        --build-arg USE_CUSTOM_SDKS=true \
        --build-arg REACT_SDK_REPO="https://github.com/matrix-org/matrix-react-sdk.git" \
        --build-arg REACT_SDK_BRANCH="develop" \
        --build-arg JS_SDK_REPO="https://github.com/matrix-org/matrix-js-sdk.git" \
        --build-arg JS_SDK_BRANCH="develop" \
        .
    
  4. Everything runs fine until error message appears:
    obraz

Outcome

What did you expect?

I expected that the command completes building the web app.

What happened instead?

Midway through and error message appeared.

Operating system

Windows 10 Pro N

Browser information

No response

URL for webapp

v1.10.1

Application version

v1.10.1

Homeserver

No response

Will you send logs?

No

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Mar 2, 2022

Based on some Googling -> https://stackoverflow.com/q/14219092/796832: It looks like you're problem has to do with a line-ending problem with Windows, \r\n vs \n.

I'm guessing that when you cloned the repo, git messed with your line endings. You probably want to follow https://stackoverflow.com/a/13154031/796832 to get LF \n line endings.

@t3chguy
Copy link
Member

t3chguy commented Apr 25, 2023

Closing due to it being a git config issue

@t3chguy t3chguy closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants