Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra space (gap) above messages #20896

Closed
MadLittleMods opened this issue Feb 3, 2022 · 6 comments
Closed

Extra space (gap) above messages #20896

MadLittleMods opened this issue Feb 3, 2022 · 6 comments
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Z-Labs

Comments

@MadLittleMods
Copy link
Contributor

Steps to reproduce

  1. Open or create a thread
  2. Send many long replies that will wrap over multiple lines
  3. Notice the gap above the first message

It looks like the extra space is caused by <ol class="mx_RoomView_MessageList" aria-live="polite" style="height: 2000px;">

chrome_2022-02-03_12-09-41

Outcome

What did you expect?

No extra random space as replies come in (space grows as more replies come in)

What happened instead?

Extra space (gap) above first message)

Operating system

Windows 10

Application version

Element version: 64242a0-react-78e78292cb62-js-b07457726bf5 Olm version: 3.2.8

How did you install the app?

https://develop.element.io/

Homeserver

matrix.org

Will you send logs?

No

@github-actions github-actions bot added the Z-Labs label Feb 3, 2022
@dbkr dbkr added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users labels Feb 4, 2022
@t3chguy
Copy link
Member

t3chguy commented Feb 18, 2022

That gap is part of the pagination mechanism in ScrollPanel, removing it makes very bad things happen (never ending backpagination), making it smaller should be sane though, but it was made 400px seemingly quite intentionally matrix-org/matrix-react-sdk@86c13b9

@MadLittleMods
Copy link
Contributor Author

@t3chguy Is the space supposed to grow with more items? PAGE_SIZE seems like a fixed value for a container 🤔

@t3chguy
Copy link
Member

t3chguy commented Feb 18, 2022

The list is effectively split into pages of that size and rounded up

@t3chguy t3chguy changed the title Extra space (gap) above messages in thread panel when messages wrap to multi-line Extra space (gap) above messages Mar 10, 2022
@t3chguy
Copy link
Member

t3chguy commented Mar 10, 2022

Not specific to thread panel nor to multi line messages

@t3chguy
Copy link
Member

t3chguy commented Mar 10, 2022

The comment around this is

// _updateHeight makes the height a ceiled multiple of this so we
// don't have to update the height too often. It also allows the user
// to scroll past the pagination spinner a bit so they don't feel blocked so
// much while the content loads.

@t3chguy
Copy link
Member

t3chguy commented May 3, 2022

Fixed by matrix-org/matrix-react-sdk#8392

@t3chguy t3chguy closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants