Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backup key setup dialogue css broken with i18n #19739

Closed
HarHarLinks opened this issue Nov 13, 2021 · 6 comments
Closed

backup key setup dialogue css broken with i18n #19739

HarHarLinks opened this issue Nov 13, 2021 · 6 comments
Labels
A-Appearance A-E2EE-Key-Backup good first issue Good for newcomers I18n O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

  1. use german element
  2. set up security key by ignoring it after login but then trying to verify a user

Outcome

image

  1. i18n?!
  2. buttons

Operating system

arch

Browser information

Vivaldi 4.4.2473.3 (Official Build) snapshot (64-bit)

URL for webapp

https://develop.element.io

Application version

Version von Element: 8e58d31-react-365950e36670-js-ad8a93dde8b4 Version von Olm: 3.2.3

Homeserver

matrix.org

Will you send logs?

No
@HarHarLinks
Copy link
Contributor Author

image

@SimonBrandner SimonBrandner added A-E2EE-Key-Backup good first issue Good for newcomers I18n A-Appearance O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Nov 13, 2021
@aaronraimist
Copy link
Collaborator

Initial post is a duplicate of #19511

I'm not sure what the second screenshot is showing, just that some things aren't translated?

@aaronraimist aaronraimist added the X-Needs-Info This issue is blocked awaiting information from the reporter label Nov 13, 2021
@HarHarLinks
Copy link
Contributor Author

Screenshots show parts that aren't translated, both related to verification, hence

  1. i18n?

@SimonBrandner
Copy link
Contributor

Though that probably just means the strings haven't been translated yet... I am going to close this as a duplicate then. If there is another issue with the missing translation that I am missing, please open a new issue for that specifically

@HarHarLinks
Copy link
Contributor Author

This is the existing translation of for the first screenshot
https://translate.element.io/translate/element-web/matrix-react-sdk/de/?checksum=3c0cb3fa4b544103&sort_by=-priority,position

it is either not merged or otherwise buggy.
If there is no other issue with the missing/broken translation, as you say there isn't, why do you close this issue instead of renaming/labeling to "German i18n broken"? The info is already here, why repost it?

@aaronraimist
Copy link
Collaborator

@HarHarLinks that string was translated 10 days ago and the last time the translations were merged was 12 days ago. It just missed the cut off for 1.9.4 but should be in the next version of Element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Appearance A-E2EE-Key-Backup good first issue Good for newcomers I18n O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HarHarLinks @aaronraimist @SimonBrandner