Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ability to add events to both top and bottom of TimelinePanel #19393

Open
Tracked by #19541
Palid opened this issue Oct 14, 2021 · 0 comments
Open
Tracked by #19541

Support ability to add events to both top and bottom of TimelinePanel #19393

Palid opened this issue Oct 14, 2021 · 0 comments
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@Palid
Copy link
Contributor

Palid commented Oct 14, 2021

Currently if we try to add an event to the timeline, the scroll position properly updates to include the bottom event, as TimelinePanel's scroll position expect that the only way you can add new events is to the end of the current timeline, which will always be the bottom of the view.
In case of ThreadPanel we are still adding events to the end of the Timeline, but the rendering order is reversed in comparison to the Room Timeline.

We need to properly account for the reversed rendering, so that the scroll position won't jump around when new events are added to the top of the view, instead of the bottom of it.

Related #18957
Follow-up to: matrix-org/matrix-react-sdk#6904

@Palid Palid added T-Task Tasks for the team like planning A-Threads labels Oct 14, 2021
@Palid Palid assigned germain-gg and unassigned germain-gg Oct 14, 2021
@Palid Palid changed the title Support two-directional scrolling in TimelinePanel component Support ability to add events to both top and bottom of TimelinePanel Oct 14, 2021
@germain-gg germain-gg self-assigned this Nov 1, 2021
@germain-gg germain-gg removed A-Threads T-Task Tasks for the team like planning labels Dec 12, 2022
@github-actions github-actions bot removed the Z-Labs label Dec 12, 2022
@germain-gg germain-gg added A-Timeline T-Enhancement O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants