Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backspace can't erase Name "bubble" after completion on firefox 78 #19077

Closed
airblag opened this issue Sep 17, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#6832
Closed

Backspace can't erase Name "bubble" after completion on firefox 78 #19077

airblag opened this issue Sep 17, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#6832
Labels
A-Composer A-Pills O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Platform-Specific

Comments

@airblag
Copy link

airblag commented Sep 17, 2021

Since a few updates (at least 1.8.2), when using Element-web in Firefox ESR, once a name is changed into the reference "bubble", you cannot delete it with backspace.

In chromium (and in the desktop client), it works as expected.

How to reproduce

  • run element-web in firefox (tested with 78 from debian).
  • In a room type the begining of a participant name and Tab to complete the name.
  • try to erase it with from the composer with backspace. It doesn't get erased

Workaround

  • User has to select the "bubble" with Shift + <- + <- to be able to erase it from the composer.
@robintown robintown added A-Composer A-Pills O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Platform-Specific labels Sep 17, 2021
@SimonBrandner SimonBrandner self-assigned this Sep 17, 2021
@SimonBrandner SimonBrandner mentioned this issue Sep 17, 2021
Merged
@SimonBrandner
Copy link
Contributor

@airblag, could you please test out the live preview on matrix-org/matrix-react-sdk#6832?

@SimonBrandner SimonBrandner mentioned this issue Sep 20, 2021
Merged
@dbkr dbkr reopened this Sep 20, 2021
@SimonBrandner SimonBrandner removed their assignment Sep 20, 2021
@ilmari
Copy link

ilmari commented Oct 5, 2021

could you please test out the live preview on matrix-org/matrix-react-sdk#6832?

@SimonBrandner I can confirm that deleting a mention pill works fine there with Firefox 78 ESR, both with backspace and delete, while it does not work on {app,staging}.element.io.

@SimonBrandner
Copy link
Contributor

@ilmari, we had to revert the fix since it broke a bunch of other things...

@robintown
Copy link
Member

Firefox ESR has moved on from 78 to 91, which doesn't have this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Composer A-Pills O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Platform-Specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pill deletion on Firefox 78 SimonBrandner/matrix-react-sdk
5 participants
@ilmari @dbkr @airblag @SimonBrandner @robintown