Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New replies show links in the message being replied to as clickable but they're not #18017

Closed
babolivier opened this issue Jul 16, 2021 · 13 comments · Fixed by matrix-org/matrix-react-sdk#6474

Comments

@babolivier
Copy link
Contributor

In that the entire message being replied to, including the link bit, is actually a link to that message in the room's timeline.

Peek 2021-07-16 11-37

@t3chguy
Copy link
Member

t3chguy commented Jul 16, 2021

It is intentional, I think the missing bit is some transition to make the event you're going to more obvious than just the slight shading. This is how other platforms like Discord do it too.

image

@babolivier
Copy link
Contributor Author

Oh, that's a pain if I have to jump to a completely different view in the timeline just to click a link, and then try to find my way back to where I was :/

@HarHarLinks
Copy link
Contributor

I agree with babolivier, it is not intuitive to me. I would like to be able to click links and open pictures right where they are shown, i.e. from the "quoted" reply.

Further links (in and outside replies) should probably have a hover effect to indicate what the on click action is.

See also #18027

@SimonBrandner
Copy link
Contributor

@niquewoodhouse, do you have any thoughts on this?

@HarHarLinks
Copy link
Contributor

I realized why I expected replied-to images to be click-to-open-viewer in the reply: URL previews already do that.

These should absolutely follow the same/similar UX for looks and interaction
image

@janogarcia
Copy link

If it looks like a link, then the user will expect it to work as such. Breaking from that default behavior is really unexpected and confusing.

We either style it as a plain-text if non-clickable or keep it as a real link. Given the current styling for quoted messages, which follows the same visual treatment as regular messages, it would be best to keep them as real links.

From a usability standpoint, I agree with @babolivier remark that it's really inconvenient to have to jump to that reply just to be able to click the link, to then jump back to the latest message.

@t3chguy
Copy link
Member

t3chguy commented Jul 26, 2021

If it looks like a link, then the user will expect it to work as such. Breaking from that default behavior is really unexpected and confusing.

Discord does this and I haven't seen it confuse users
image

hartk here is a link to a user but clicking anywhere including on hartk takes you back to the message and not that user.

@janogarcia
Copy link

It's an interesting example. Thanks, @t3chguy. But even if it's a popular and successful pattern on a specific platform, that doesn't necessarily mean that it's going to be equally successful for the masses and every possible context.

We'd be introducing a breaking change for one of the most natural interactions on web. Following a link. Giving priority instead to a secondary action instead. Going back to a quoted message. I mean, if someone is specifically hovering the link text/URL and clicks on it, what is her intent?, what would be the expected behavior?, what's the most relevant thing that should happen according to the user's intent?

@babolivier
Copy link
Contributor Author

babolivier commented Jul 26, 2021

fwiw I think the reason it might work on discord (even if I also find it meh over there personally) is because Discord makes it look much more like a preview of the message being replied to (preview appears in a small font, above the user's name/avatar, truncated quite shortly, less style on links etc (iirc), etc.) whereas Element's replies look much more like quoting the message before the reply, which I think is why people are confused about why they can't select the text, click links, etc. (i.e. Element makes it look like the original message is part of the reply whereas Discord doesn't)

@SimonBrandner
Copy link
Contributor

matrix-org/matrix-react-sdk#6396 changes that a bit though it's still not completely like Discord

@janogarcia
Copy link

Agree, @babolivier. That's actually what I meant by "Given the current styling for quoted messages, which follows the same visual treatment as regular messages, it would be best to keep them as real links.".

@babolivier
Copy link
Contributor Author

Gah, I guess I skimmed too quickly over your message @janogarcia, my bad!

@janogarcia
Copy link

No worries, @babolivier! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants