-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New replies show links in the message being replied to as clickable but they're not #18017
Comments
Oh, that's a pain if I have to jump to a completely different view in the timeline just to click a link, and then try to find my way back to where I was :/ |
I agree with babolivier, it is not intuitive to me. I would like to be able to click links and open pictures right where they are shown, i.e. from the "quoted" reply. Further links (in and outside replies) should probably have a hover effect to indicate what the on click action is. See also #18027 |
@niquewoodhouse, do you have any thoughts on this? |
If it looks like a link, then the user will expect it to work as such. Breaking from that default behavior is really unexpected and confusing. We either style it as a plain-text if non-clickable or keep it as a real link. Given the current styling for quoted messages, which follows the same visual treatment as regular messages, it would be best to keep them as real links. From a usability standpoint, I agree with @babolivier remark that it's really inconvenient to have to jump to that reply just to be able to click the link, to then jump back to the latest message. |
It's an interesting example. Thanks, @t3chguy. But even if it's a popular and successful pattern on a specific platform, that doesn't necessarily mean that it's going to be equally successful for the masses and every possible context. We'd be introducing a breaking change for one of the most natural interactions on web. Following a link. Giving priority instead to a secondary action instead. Going back to a quoted message. I mean, if someone is specifically hovering the link text/URL and clicks on it, what is her intent?, what would be the expected behavior?, what's the most relevant thing that should happen according to the user's intent? |
fwiw I think the reason it might work on discord (even if I also find it meh over there personally) is because Discord makes it look much more like a preview of the message being replied to (preview appears in a small font, above the user's name/avatar, truncated quite shortly, less style on links etc (iirc), etc.) whereas Element's replies look much more like quoting the message before the reply, which I think is why people are confused about why they can't select the text, click links, etc. (i.e. Element makes it look like the original message is part of the reply whereas Discord doesn't) |
matrix-org/matrix-react-sdk#6396 changes that a bit though it's still not completely like Discord |
Agree, @babolivier. That's actually what I meant by "Given the current styling for quoted messages, which follows the same visual treatment as regular messages, it would be best to keep them as real links.". |
Gah, I guess I skimmed too quickly over your message @janogarcia, my bad! |
No worries, @babolivier! 😄 |
In that the entire message being replied to, including the link bit, is actually a link to that message in the room's timeline.
The text was updated successfully, but these errors were encountered: