Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't scroll up in the right message panel #17567

Closed
SimonBrandner opened this issue Jun 5, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6154
Closed

Can't scroll up in the right message panel #17567

SimonBrandner opened this issue Jun 5, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6154
Assignees
@DantrazTrev
Labels
A-Right-Panel P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@SimonBrandner
Copy link
Contributor

Peek 2021-06-05 07-47
@SimonBrandner SimonBrandner added T-Defect P1 X-Regression A-Right-Panel S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jun 5, 2021
@DantrazTrev
Copy link

DantrazTrev commented Jun 5, 2021 •
edited
Loading

Seems like the bug occurs when the timeline is backpaginating.
Probably has something to do with not passing the added onUserScroll props for the FilePanel which was not there in earlier builds and is used in ScrollPanel.js for the wheel scroll?

If anyone else is not working I would like to take this up

@SimonBrandner
Copy link
Contributor Author

If anyone else is not working I would like to take this up

Sure, go ahead!

@DantrazTrev
Copy link

Update:
Things probably regressed here matrix-org/matrix-react-sdk/pull/6079 . Specifically due to the relocating of shouldComponentUpdate from TimelinePanel to RoomView which causes the scroll component to be rerendered at every state update hence when the onCheckupPrefill is called when we scroll close to the top and backpaginating is set to true the ScrollPanel resets, also if you change any parent state similar change is observed

Also when there is a new message in the timeline it resets , which is weird and unrelated.

@DantrazTrev DantrazTrev mentioned this issue Jun 6, 2021
Closed
@germain-gg germain-gg mentioned this issue Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DantrazTrev DantrazTrev

Labels
A-Right-Panel P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
2 participants
@SimonBrandner @DantrazTrev