Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening the Spaces Feedback modal will close any modals that are currently open #17306

Closed
anoadragon453 opened this issue May 15, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6334
Assignees
Labels
A-Spaces Spaces, groups, communities P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@anoadragon453
Copy link
Member

anoadragon453 commented May 15, 2021

Description

Say you're in a space and currently editing the settings of the space, like so:

image

You write a big description and then think "hmm, I really wish I could also add a foobar field to this form". So before you hit Save you hit the "Send feedback" form, write your constructive feedback and hit Send feedback.

You're then taken back to the Manage your Space page, your previous modal and your written up description lost to the wind ☁️

Steps to reproduce

  • Open a modal window that involves spaces
  • Click the "Feedback" button
  • Watch your previous modal be replaced, instead of put below, the Spaces Feedback modal

Ideally it would just spawn on top instead of replacing the current modal.

Logs being sent: no

Version information

  • Platform: web
  • Browser: Firefox
  • OS: Arch Linux
  • URL: develop.element.io (latest commits across repos as of today)
@t3chguy
Copy link
Member

t3chguy commented May 15, 2021

This was done semi-on-purpose as our stacked modals kinda suck :(

@t3chguy t3chguy added the A-Spaces Spaces, groups, communities label May 15, 2021
@anoadragon453
Copy link
Member Author

Aha OK. I know the spaces feedback button is only temporary, but I assumed fixing this would have some sort of lasting implication. Especially if we decide the implement the same system for future features.

@jryans jryans added P2 S-Minor Impairs non-critical functionality or suitable workarounds exist labels May 17, 2021
@t3chguy t3chguy self-assigned this Jul 8, 2021
@t3chguy
Copy link
Member

t3chguy commented Jul 8, 2021

We can fix this for the settings dialog, but not the add existing to space dialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants