Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop.element.io with Spaces enabled switching rooms and spaces on its own #17017

Closed
tanriol opened this issue Apr 20, 2021 · 8 comments · Fixed by matrix-org/matrix-react-sdk#5891
Assignees
Labels

Comments

@tanriol
Copy link

tanriol commented Apr 20, 2021

Description

After a recent develop.elements.io update my develop.element.io client with Spaces enabled got stuck in an infinite loop switching between rooms and spaces on its own without any additional user input. I've got a number of private spaces for grouping rooms and the loop involves at least one room included in more than one space and both spaces that include it.

The weird switching started before the loop and looked like this:

  • I click a different space
  • the space opens and some room opens
  • space selection goes back to the one I was in
  • room changes again
  • result: I'm back in the same room where I were unable to go into rooms in the other space

Environment

develop.element.io with Spaces enabled, Firefox Nightly, Linux
The problem started after an update that included matrix-org/matrix-react-sdk#5795, which looks like a likely cause, so cc @SimonBrandner @t3chguy

@SimonBrandner
Copy link
Contributor

I'd like to apologize to anyone who has been affected by this. It looks like something I have encountered before but wasn't able to repro then.

@tanriol, could you please try out the live preview here when it's available and confirm that it solves the problem?

I am still having issue trying to find an exact repro case

@SimonBrandner
Copy link
Contributor

@tanriol, here is the live preview. Could you please try? It sometimes takes some time to load so be patient please

@SimonBrandner
Copy link
Contributor

To reproduce:

  • Go to home space
  • Click Manage and Explore on another space
  • Try to switch to the home space and it will take you back

@tanriol
Copy link
Author

tanriol commented Apr 20, 2021

I haven't managed to reproduce the problem in the live preview. However, note that the "Manage and Explore" context menu entry on another space is useless with this feature because it causes a space switch and then a room switch to the remembered one.

@SimonBrandner
Copy link
Contributor

Yeah, this is a bug

@SimonBrandner SimonBrandner self-assigned this Apr 20, 2021
@tanriol
Copy link
Author

tanriol commented Apr 20, 2021

Also I'm not sure how to get out to normal state now - "Clear cache and reload" does not seem to kill this remembered room and your fix is in the save path, not load, so it probably won't do that. Looks like I'll need to clear site data completely.

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Apr 20, 2021

Once again I am really sorry about this. Hit F12 → Go to Storage → Go to Local Storage → And delete everything that begins with mx_last_viewed_rooms_

Screenshot_20210420_161839

@SimonBrandner
Copy link
Contributor

If anyone has any further problems with this, please visit this room

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants