Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Image View feedback #16961

Closed
3 of 4 tasks
SimonBrandner opened this issue Apr 15, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#5872
Closed
3 of 4 tasks

New Image View feedback #16961

SimonBrandner opened this issue Apr 15, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#5872
Assignees
Labels
T-Task Tasks for the team like planning X-Release-Blocker

Comments

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Apr 15, 2021

This issue is to gather any feedback regarding the new Image View so that I could make bugfix/improvement PR later

  • Zooming using the scroll wheel is too fast
  • Right-click triggers zoom
  • Clickable area is bigger than it should be (this was caused by the image itself)
  • Opening pictures from the right panel sometimes fails (tracked in #5692)
@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2021

  • We lost the image metadata e.g size & resolution

😢

@jryans
Copy link
Collaborator

jryans commented Apr 19, 2021

[ ] We lost the image metadata e.g size & resolution

@SimonBrandner Maybe make a new issue for anything that remains...? Or reopen this one if you plan to address it before the RC.

@SimonBrandner
Copy link
Contributor Author

@jryans, currently there are two problems:

  1. Opening pictures from the right panel sometimes fails - this one seems to have the same cause as #5692, so I think we can track it there. I'd like to address this before the RC but I am not sure I can. I am missing some js-sdk knowledge and the solution proposed by @t3chguy doesn't seem to work (see this). I'll try to do more digging
  2. We lost the image metadata e.g size & resolution - this was intentionally removed by @niquewoodhouse. I am not sure how necessary it is to revert that change. It would probably be best if @t3chguy made new issue for it, if he wants as it will need the design team to look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning X-Release-Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants