Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read receipts don't come down to the latest message in the room #16646

Closed
babolivier opened this issue Mar 9, 2021 · 27 comments · Fixed by matrix-org/matrix-react-sdk#5836
Closed

Comments

@babolivier
Copy link
Contributor

babolivier commented Mar 9, 2021

Peek 2021-03-09 10-48

As you can see, the message is read (send status disappears) but the RR doesn't come down - it only does when I switch rooms (I switched to my DM with @benparsons and back hence why his RR briefly appears at the end). I control both accounts involved in the DM I'm doing tests in so can confirm the message isn't read while switching rooms.

Using develop.element.io with Firefox 85.0, and have sent logs.

@turt2live
Copy link
Member

@babolivier was the message edited?

@babolivier
Copy link
Contributor Author

babolivier commented Mar 9, 2021

@turt2live No

@turt2live
Copy link
Member

I need a bunch of other information then, as I cannot reproduce this.

  • Who was the sender of the message? (you or someone else?)
  • What operating system are you using?
  • Do you have reduced motion enabled in your OS or browser?

@turt2live turt2live added X-Cannot-Reproduce X-Needs-Info This issue is blocked awaiting information from the reporter labels Mar 9, 2021
@babolivier
Copy link
Contributor Author

Who was the sender of the message? (you or someone else?)

Me.

What operating system are you using?

This was develop.element.io with Firefox 85.0 on ArchLinux.

Do you have reduced motion enabled in your OS or browser?

I haven't purposefully enabled it and am not sure how to check what state it's in.

@turt2live
Copy link
Member

is that a fork of firefox or regular off-the-shelf firefox?

@turt2live
Copy link
Member

also which desktop environment are you using?

@babolivier
Copy link
Contributor Author

babolivier commented Mar 9, 2021

is that a fork of firefox or regular off-the-shelf firefox?

Regular off-the-shelf (pacman -S firefox) firefox

also which desktop environment are you using?

Gnome version 3.38.3

@turt2live
Copy link
Member

alright, I'm suspecting this has something to do with your OS rather than Element/Firefox

@turt2live turt2live removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Mar 9, 2021
@babolivier
Copy link
Contributor Author

Hmm, any idea how to debug this? It's a pretty standard setup (without much customisation) so I'm a bit surprised to hear that.

@turt2live
Copy link
Member

Honestly not sure. I can't get an arch VM going to test myself, but all other testing points to it being a problem with your setup specifically :(

If you have another device to test with, I'd try that and see what happens.

@turt2live
Copy link
Member

@babolivier has this been better on updated versions of develop?

@babolivier
Copy link
Contributor Author

Not as far as I can tell.

@turt2live
Copy link
Member

ugh, this is going to be not very fun to diagnose

@shmerl
Copy link

shmerl commented Mar 18, 2021

I have the same issue.

Debian testing Linux, Firefox 87.0.

I wonder how can it be OS related? It should be purely browser driven issue? Is it working OK for Firefox users on Windows let's say?

Also, I had "Enhanced tracking protection" on in Firefox. I disabled it for now for Element to see if it has any effect.

@turt2live
Copy link
Member

It's working fine for me in Firefox on Linux and Windows, which is part of the problem.

@shmerl
Copy link

shmerl commented Mar 18, 2021

When looking in console, I see some messages like:

Error: request failed: CORS request rejected: https://matrix-client.matrix.org/_matrix/client/r0/sync...
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://matrix-client.matrix.org/_matrix/media/... (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

And

Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”).
Content Security Policy: The page’s settings blocked the loading of a resource at blob:https://app.element.io/...

Not sure if any of that is related to the above, but just noting the errors.

@shmerl
Copy link

shmerl commented Mar 18, 2021

It seems to be working better with tracking protection turned off. I'll keep monitoring it.

@turt2live
Copy link
Member

is anyone still seeing this in recent versions of develop?

@babolivier
Copy link
Contributor Author

Yeah I can still see it on develop.element.io

@turt2live
Copy link
Member

ugh, that's annoying. Any chance of trying other browsers/desktop environments to see if it fixes itself? or trying the desktop app?

@babolivier
Copy link
Contributor Author

Sure, I'll give that a try next week.

@babolivier
Copy link
Contributor Author

babolivier commented Mar 29, 2021

I've had a try in Chrome 89.0.4389.90 (still on Gnome because I've only got this DE set up), I couldn't reproduce this specific issue and could see the animation when a RR goes down (which I don't see on Firefox), but I could also see RRs stacking on top of each other and holes (e.g. image or image).

@babolivier
Copy link
Contributor Author

babolivier commented Mar 29, 2021

I've just had a try in Firefox after manually disabling tracking protection and it seems to now match what I'm seeing in Chrome. nvm I can still reproduce what I was seeing initially, just that now there's an animation when a RR goes down

@turt2live
Copy link
Member

that's at least progress - so disabling tracking protection (either by using chrome or within firefox) is at least giving you animations? If so, the holes might be a different animation issue or the media repo being slow - if you hover hover a where an avatar would be, do you get a cursor change and tooltip of a user ID? If not, boo. If yes, it's just the media repo at that point.

@babolivier
Copy link
Contributor Author

so disabling tracking protection (either by using chrome or within firefox) is at least giving you animations?

Yes looks like it.

if you hover hover a where an avatar would be, do you get a cursor change and tooltip of a user ID?

Nope :/

@turt2live
Copy link
Member

The next step on this is #16554 ftr

@babolivier
Copy link
Contributor Author

Can confirm that matrix-org/matrix-react-sdk#5836 fixes all issues with read receipts from my pov 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants