Failure to invite from the button in the top-right

[ara4n]

InviteDialog.js?5ac8:354 Uncaught TypeError: dmTaggedRooms is not iterable
    at InviteDialog._buildRecents (InviteDialog.js?5ac8:354)
    at new InviteDialog (InviteDialog.js?5ac8:330)
    at constructClassInstance (react-dom.development.js?61bb:12880)
    at updateClassComponent (react-dom.development.js?61bb:17100)
    at beginWork (react-dom.development.js?61bb:18620)
    at HTMLUnknownElement.callCallback (react-dom.development.js?61bb:188)
    at Object.invokeGuardedCallbackDev (react-dom.development.js?61bb:237)
    at invokeGuardedCallback (react-dom.development.js?61bb:292)
    at beginWork$1 (react-dom.development.js?61bb:23203)
    at performUnitOfWork (react-dom.development.js?61bb:22157)
_buildRecents @ InviteDialog.js?5ac8:354
InviteDialog @ InviteDialog.js?5ac8:330
constructClassInstance @ react-dom.development.js?61bb:12880
updateClassComponent @ react-dom.development.js?61bb:17100
beginWork @ react-dom.development.js?61bb:18620
callCallback @ react-dom.development.js?61bb:188
invokeGuardedCallbackDev @ react-dom.development.js?61bb:237
invokeGuardedCallback @ react-dom.development.js?61bb:292
beginWork$1 @ react-dom.development.js?61bb:23203
performUnitOfWork @ react-dom.development.js?61bb:22157
workLoopSync @ react-dom.development.js?61bb:22130
performSyncWorkOnRoot @ react-dom.development.js?61bb:21756
eval @ react-dom.development.js?61bb:11089
unstable_runWithPriority @ scheduler.development.js?3069:653
runWithPriority$1 @ react-dom.development.js?61bb:11039
flushSyncCallbackQueueImpl @ react-dom.development.js?61bb:11084
flushSyncCallbackQueue @ react-dom.development.js?61bb:11072
scheduleUpdateOnFiber @ react-dom.development.js?61bb:21199
enqueueSetState @ react-dom.development.js?61bb:12639
Component.setState @ react.development.js?72d0:471
eval @ AsyncWrapper.js?2ab6:54
Promise.then (async)
componentDidMount @ AsyncWrapper.js?2ab6:46
chainedFunction @ factory.js?c96a:665
commitLifeCycles @ react-dom.development.js?61bb:19814
commitLayoutEffects @ react-dom.development.js?61bb:22803
callCallback @ react-dom.development.js?61bb:188
invokeGuardedCallbackDev @ react-dom.development.js?61bb:237
invokeGuardedCallback @ react-dom.development.js?61bb:292
commitRootImpl @ react-dom.development.js?61bb:22541
unstable_runWithPriority @ scheduler.development.js?3069:653
runWithPriority$1 @ react-dom.development.js?61bb:11039
commitRoot @ react-dom.development.js?61bb:22381
finishSyncRender @ react-dom.development.js?61bb:21807
performSyncWorkOnRoot @ react-dom.development.js?61bb:21793
eval @ react-dom.development.js?61bb:11089
unstable_runWithPriority @ scheduler.development.js?3069:653
runWithPriority$1 @ react-dom.development.js?61bb:11039
flushSyncCallbackQueueImpl @ react-dom.development.js?61bb:11084
flushSyncCallbackQueue @ react-dom.development.js?61bb:11072
scheduleUpdateOnFiber @ react-dom.development.js?61bb:21199
updateContainer @ react-dom.development.js?61bb:24373
legacyRenderSubtreeIntoContainer @ react-dom.development.js?61bb:24774
render @ react-dom.development.js?61bb:24840
reRender @ Modal.tsx?e006:351
createDialogAsync @ Modal.tsx?e006:280
createDialog @ Modal.tsx?e006:122
createTrackedDialog @ Modal.tsx?e006:106
showRoomInviteDialog @ RoomInvite.js?6cbb:53
eval @ MatrixChat.tsx?b3f7:657
_invokeCallback @ Dispatcher.js?f5a1:198
dispatch @ Dispatcher.js?f5a1:174
setTimeout (async)
dispatch @ dispatcher.ts?75fd:51
onInviteButtonClick @ MemberList.js?99cf:513
callCallback @ react-dom.development.js?61bb:188
invokeGuardedCallbackDev @ react-dom.development.js?61bb:237
invokeGuardedCallback @ react-dom.development.js?61bb:292
invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js?61bb:306
executeDispatch @ react-dom.development.js?61bb:389
executeDispatchesInOrder @ react-dom.development.js?61bb:414
executeDispatchesAndRelease @ react-dom.development.js?61bb:3278
executeDispatchesAndReleaseTopLevel @ react-dom.development.js?61bb:3287
forEachAccumulated @ react-dom.development.js?61bb:3259
runEventsInBatch @ react-dom.development.js?61bb:3304
runExtractedPluginEventsInBatch @ react-dom.development.js?61bb:3514
handleTopLevel @ react-dom.development.js?61bb:3558
batchedEventUpdates$1 @ react-dom.development.js?61bb:21871
batchedEventUpdates @ react-dom.development.js?61bb:795
dispatchEventForLegacyPluginEventSystem @ react-dom.development.js?61bb:3568
attemptToDispatchEvent @ react-dom.development.js?61bb:4267
dispatchEvent @ react-dom.development.js?61bb:4189
unstable_runWithPriority @ scheduler.development.js?3069:653
runWithPriority$1 @ react-dom.development.js?61bb:11039
discreteUpdates$1 @ react-dom.development.js?61bb:21887
discreteUpdates @ react-dom.development.js?61bb:806
dispatchDiscreteEvent @ react-dom.development.js?61bb:4168

11:27:34.659 rageshake.js?432e:65 The above error occurred in the <InviteDialog> component:
    in InviteDialog (created by AsyncWrapper)
    in AsyncWrapper
    in div
    in div

[t3chguy]

https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/components/views/dialogs/InviteDialog.js#L352 is a very broken assumption as it doesn't account for DMs which are in Favourites instead.

[turt2live]

It's not broken, it's not meant to catch that case. The DMRoomMap will catch the rooms which are favourited DMs but there can be rooms which are in the DM section which are unknown to the map, hence the grab.

[ara4n]

this is biting more people than just me.