-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't grant media permissions from latest Firefox #10021
Comments
I have the exact same issue. I'm on Linux with Firefox 67.0. |
I see a related failure in Firefox 69 on macOS:
|
We're filtering devices without a label upon permission. On my FF 67 none of the devices have a label, probably do to fingerprinting protection. |
Ah, sounds likely to be related... Looking through Firefox source, it seems like you only get device labels if a stream is active or if you grant persistent permission. And indeed, if I check "Remember this decision" in the browser permission prompt, the devices come through. |
Maybe we need to clarify that you should grant persistent permission...? |
Hmm... right. Without persistent permission, you'll get asked anyway again what devices you want to use by the browser once you set up a call, making these preferences sort of useless. I did the above PR, but wonder if we should instead hide this preference in the browser (as opposed to electron) ... ? |
Not all browsers prompt you nicely |
I think we should merge the above PR, as I think it will at least allow people to make calls after setting the preferred devices in the settings, even though it's not the perfect solution for now. |
@babolivier & @cyphar: could you please try again on /develop with above PR merged? Thanks 🙏 |
The issue is still here on latest develop. |
Hmm, could you please share what the permissions and blocking overlay says @babolivier as below? Also, this is not in a private window, is it? |
Missed:
Nope, it's not. |
@cyphar, @babolivier: thank you both for the extra input. On latest develop, is this (still) preventing you from making webrtc calls? |
One user appears to have encountered this and fixed it by adjusting their privacy settings in Windows 10. They had the microphone and camera blocked for all apps, therefore Firefox wasn't able to get at them. Might not help everyone here, but might help someone. |
@babolivier & @cyphar: could you please try to see if your camera and microphone work on the page below? It's a demo page I've put together to diagnose this issue. The steps are bit involved, so thank you in advance if you're willing to help out!
Please paste both device listings here, with any errors you encountered, and whether the video feed appeared. The page is up at https://bwindels.github.io/mediadevices.html Thanks again! |
1st list:
Open media: When clicking this button I get hit by this error message in a dialog for each of the listed devices:
|
@babolivier interesting, do you also see a line number for that error in the console? |
Thanks @babolivier. I made some changes, could you have another go and report all the info on the page please? Please try with both selecting and not selecting devices for each category. |
With one device selectedError
requested constraints
obtained tracks with constraints
getSupportedConstraints()
With no device selectedError
requested constraints
obtained tracks with constraints
getSupportedConstraints()
Note that:
|
@babolivier Interesting! Do audio calls work on Riot for you? |
I haven't tried them, given I can't recognise my microphone due to lack of labels. On Jitsi, which I assume remembers what device I was previously using, they do work (and access to my webcam fails), though. |
And if you ignore the preferences and just start an voice call, and then pick the right microphone in the permissions dialog? Feel free to call me if you need a guinea pig. Also, one last test, sorry for all the hassle, can you try the "Open Audio media" button on the page? just added it. Thanks! |
This one actually asks me for permission for my mic, and apparently manages to open it. |
@babolivier great, with and without choosing a device, no difference? |
The only difference between both is that, when selecting a device, the default value of the request overlay changes (presumably to the name of the device that has the ID I selected) |
Webcam missing seems like a recent firefox bug. Wrt to missing labels, I'll make some changes to show the permission popup before showing the selector in the preferences, so we get accurate labels for the devices. Also need to give better feedback for users that don't have a webcam (recognized). Confirmed with @babolivier that voice calls work in Riot when webcam isn't recognized. |
@babolivier should work now on https://riot.im/develop/ |
It does, thanks :) |
Using Firefox 67.0.2, Riot can't access my microphone and camera. When I go to the settings and try to ask for permissions here's what I get:
This started happening after I upgraded Firefox to 67.0.1 then 67.0.2 earlier this week.
This happens on both /develop and /app
The text was updated successfully, but these errors were encountered: