Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room listed in directory only if Only people who have been invited is unchecked #1141

Open
pedroGitt opened this issue Jun 1, 2016 · 4 comments
Labels
A-Room-Directory A-Room-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Synapse

Comments

@pedroGitt
Copy link

In the room settings:

  1. check List this room in matrix.org's room directory? option
  2. check Only people who have been invited option
  3. go to directory
  4. search for the room name
  5. the room is not found
@pedroGitt
Copy link
Author

pedroGitt commented Jun 1, 2016

It appears that the fact the room is listed in the room directory depends on if one of the following options:

  • Anyone who knows the room's link, apart from guests
  • Anyone who knows the room's link, including guests

is checked.

@pedroGitt pedroGitt changed the title [Room Settings] room listed in directory only if "Only people who have been invited" is **uncheked** [Room Settings] room listed in directory only if "Only people who have been invited" is uncheked Jun 1, 2016
@ara4n
Copy link
Member

ara4n commented Jun 18, 2016

This sounds like synapse trying to stop private rooms from being leaked in the room directory. Unsure whether we should let people (accidentally) publish private rooms in the directory or not. We probably should, but need to be careful that it doesn't leak lots of private rooms in the current DBs... @erikjohnston , any idea if this would pose a problem?

@ara4n ara4n added T-Defect P2 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jun 18, 2016
@tanius
Copy link

tanius commented Jul 4, 2017

There might be a simple way to solve this as a UI tweak:

Private rooms are of no use in the directory, as one cannot join them without an invitation, cannot request an invitation, or do any other action with them. So the current behaviour of synapse to not list them seems reasonable (to me). To reflect that in the Riot UI room settings, it could look like this:


WHO CAN ACCESS THIS ROOM?

  • Only people who have been invited
  • Anyone who knows the room's link, apart from guests
    • List this room in example.com's room directory?
  • Anyone who knows the room's link, including guests
    • List this room in example.com's room directory?

(Represents three radio buttons and two checkboxes, which only become active / check-able when their respective parent radio buttons have been selected.)

@leenzhu
Copy link

leenzhu commented Feb 13, 2018

Perhaps if the knocking fearture(matrix-org/matrix-spec-proposals#932) is implenmented, room which can't join directly, is expected bing listed in directory.

@MadLittleMods MadLittleMods added A-Room-Directory O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 2, 2022
@MadLittleMods MadLittleMods changed the title [Room Settings] room listed in directory only if "Only people who have been invited" is uncheked Room listed in directory only if Only people who have been invited is unchecked Sep 2, 2022
@t3chguy t3chguy transferred this issue from element-hq/element-web Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-Directory A-Room-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Synapse
Projects
None yet
Development

No branches or pull requests

7 participants