Analytics | Add support for super properties and appPlatform #7801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
approved these changes
Jun 3, 2024
Comment on lines
-30
to
+47
| var isRunning: Bool { postHog != nil && !postHog!.isOptOut() } | ||
| var isRunning: Bool { | ||
| guard let postHog else { return false } | ||
| return !postHog.isOptOut() | ||
| } |
Co-authored-by: Doug <[email protected]>
Co-authored-by: Doug <[email protected]>
Co-authored-by: Doug <[email protected]>
Co-authored-by: Doug <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for posthog super properties (added to all events).
The analytics-event dependency has been updated to latest release.
In order to add unit test I had to introduce a protocol interface for PostHog and added some Mock classes.
Fixes https://github.com/element-hq/crypto-internal/issues/322
Pull Request Checklist