Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labs: Rich text editor: enable list items indentation #7317

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

aringenbach
Copy link
Contributor

Fixes #7316

Also:

  • updates composer library to 0.22.0 (integrates rework to support paragraphs, improvements on behaviour for quote/code blocks/lists/links)
  • move DTCoreText dependency to SPM to avoid duplication
  • update DTCoreText to use version 1.6.27
  • removed swizzling workaround for DTCoreText font issues since the composer library provides it

@aringenbach aringenbach added the Trigger-PR-Build Label to trigger builds for PRs label Jan 30, 2023
@aringenbach aringenbach requested review from a team and pixlwave and removed request for a team January 30, 2023 14:48
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yP31Dg

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 12.02% // Head: 12.01% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (4e0a127) compared to base (4a2a057).
Patch coverage: 54.94% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7317      +/-   ##
===========================================
- Coverage    12.02%   12.01%   -0.02%     
===========================================
  Files         1629     1629              
  Lines       161185   161224      +39     
  Branches     66037    66068      +31     
===========================================
- Hits         19387    19372      -15     
- Misses      141154   141203      +49     
- Partials       644      649       +5     
Flag Coverage Δ
uitests 55.66% <75.38%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Analytics/DecryptionFailure.swift 0.00% <ø> (ø)
Riot/Modules/Analytics/DecryptionFailureTracker.m 35.22% <ø> (ø)
...alytics/Helpers/MXCallHangupReason+Analytics.swift 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
Riot/Utils/EventFormatter.m 7.61% <0.00%> (-0.44%) ⬇️
.../Modules/Common/Avatar/View/SpaceAvatarImage.swift 39.72% <54.54%> (ø)
...I/Modules/Room/Composer/Model/ComposerModels.swift 77.39% <80.00%> (+0.41%) ⬆️
...ules/Common/Avatar/ViewModel/AvatarViewModel.swift 90.00% <90.90%> (ø)
...iftUI/Modules/Common/Avatar/View/AvatarImage.swift 71.42% <91.66%> (ø)
...MatrixKit/Utils/EventFormatter/HTMLFormatter.swift 71.92% <100.00%> (-0.96%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Comment on lines +262 to +263
# Fix XCode 14 code signing issues for Swift packages containing resources bundles.
"CODE_SIGN_STYLE" => "Manual",
Copy link
Contributor Author

@aringenbach aringenbach Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pixlwave This fixes the Diawi build, I suppose it wont break anything else, but I'd rather put a bit of spotlight on this specific change just in case.

Copy link
Member

@pixlwave pixlwave Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sounds fine to me. The only other place that might be worth double checking could be the build script:
./Tools/Release/buildRelease.sh aringenbach/7316_indentation_support

@aringenbach aringenbach merged commit 2aaef07 into develop Feb 1, 2023
@aringenbach aringenbach deleted the aringenbach/7316_indentation_support branch February 1, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger-PR-Build Label to trigger builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labs: Rich text editor: Add indent/unIndent support for lists
2 participants