-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labs: Rich text editor: enable list items indentation #7317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yP31Dg |
Codecov ReportBase: 12.02% // Head: 12.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7317 +/- ##
===========================================
- Coverage 12.02% 12.01% -0.02%
===========================================
Files 1629 1629
Lines 161185 161224 +39
Branches 66037 66068 +31
===========================================
- Hits 19387 19372 -15
- Misses 141154 141203 +49
- Partials 644 649 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Kudos, SonarCloud Quality Gate passed! |
# Fix XCode 14 code signing issues for Swift packages containing resources bundles. | ||
"CODE_SIGN_STYLE" => "Manual", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pixlwave This fixes the Diawi build, I suppose it wont break anything else, but I'd rather put a bit of spotlight on this specific change just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sounds fine to me. The only other place that might be worth double checking could be the build script:
./Tools/Release/buildRelease.sh aringenbach/7316_indentation_support
Fixes #7316
Also: