Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xcversion to 14.2 #7187

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

paleksandrs
Copy link
Contributor

@paleksandrs paleksandrs commented Dec 19, 2022

closes #7182

@paleksandrs paleksandrs marked this pull request as ready for review December 19, 2022 15:52
@stefanceriu stefanceriu added the Trigger-PR-Build Label to trigger builds for PRs label Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 11.82% // Head: 11.84% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c4e0062) compared to base (710b09e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7187      +/-   ##
===========================================
+ Coverage    11.82%   11.84%   +0.01%     
===========================================
  Files         1628     1628              
  Lines       159996   160077      +81     
  Branches     65241    65349     +108     
===========================================
+ Hits         18924    18961      +37     
- Misses      140429   140479      +50     
+ Partials       643      637       -6     
Flag Coverage Δ
uitests 54.84% <ø> (+0.10%) ⬆️
unittests 5.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Utils/EventFormatter.m 8.66% <0.00%> (-1.30%) ⬇️
...herSessions/View/UserOtherSessionsHeaderView.swift 52.83% <0.00%> (-0.88%) ⬇️
...ionsOverview/View/SecurityRecommendationCard.swift 82.60% <0.00%> (-0.25%) ⬇️
Riot/Modules/Room/CellData/RoomBubbleCellData.m 0.00% <0.00%> (ø)
...Modules/Common/Recents/Views/RecentTableViewCell.m 0.00% <0.00%> (ø)
...dules/UserSessions/Common/View/SeparatorLine.swift 100.00% <0.00%> (ø)
...t/VoiceBroadcastSDK/VoiceBroadcastAggregator.swift 0.00% <0.00%> (ø)
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...castRecorder/View/VoiceBroadcastRecorderView.swift 0.00% <0.00%> (ø)
...ceBroadcast/VoiceBroadcastSDK/VoiceBroadcastInfo.m
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanceriu stefanceriu added Trigger-PR-Build Label to trigger builds for PRs and removed Trigger-PR-Build Label to trigger builds for PRs labels Dec 19, 2022
@stefanceriu stefanceriu force-pushed the aleksandrs/7182_update_xcversion branch from 1ef6647 to c4e0062 Compare December 20, 2022 09:04
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/DG7nyv

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI seems happy so that's good enough for me 👍

@paleksandrs paleksandrs merged commit 80d3f57 into develop Dec 20, 2022
@paleksandrs paleksandrs deleted the aleksandrs/7182_update_xcversion branch December 20, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger-PR-Build Label to trigger builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't build, xcversion deprecated
2 participants