Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoiceBroadcast: Link the live icon color to the recording state #7172

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Dec 15, 2022

@phloux phloux changed the base branch from develop to phlpro/voice_broadcast_player_timeline December 15, 2022 15:32
@phloux phloux force-pushed the phlpro/voice_broadcast_live_button branch from 93f755c to c4a4112 Compare December 15, 2022 15:35
@phloux phloux changed the base branch from phlpro/voice_broadcast_player_timeline to develop December 15, 2022 15:36
@phloux phloux marked this pull request as ready for review December 15, 2022 15:37
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 11.73% // Head: 11.83% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (c4a4112) compared to base (9c13411).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7172      +/-   ##
===========================================
+ Coverage    11.73%   11.83%   +0.10%     
===========================================
  Files         1627     1628       +1     
  Lines       159892   159945      +53     
  Branches     65167    65179      +12     
===========================================
+ Hits         18756    18924     +168     
+ Misses      140492   140383     -109     
+ Partials       644      638       -6     
Flag Coverage Δ
uitests 54.74% <0.00%> (+0.06%) ⬆️
unittests 5.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 84.31% <0.00%> (-5.89%) ⬇️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 80.39% <0.00%> (ø)
...ck/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift 0.00% <0.00%> (ø)
...eBroadcastPlayback/View/VoiceBroadcastSlider.swift 0.00% <0.00%> (ø)
.../Modules/Common/Util/BorderedInputFieldStyle.swift 51.11% <0.00%> (+3.33%) ⬆️
...dules/Common/Util/SecondaryActionButtonStyle.swift 33.33% <0.00%> (+4.44%) ⬆️
...es/Room/Composer/ViewModel/ComposerViewModel.swift 31.37% <0.00%> (+5.44%) ⬆️
...List/MockComposerCreateActionListScreenState.swift 100.00% <0.00%> (+18.51%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@giomfo giomfo self-assigned this Dec 16, 2022
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tests ok

@phloux phloux merged commit 2a80735 into develop Dec 16, 2022
@phloux phloux deleted the phlpro/voice_broadcast_live_button branch December 16, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants