Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text Editor: Fix for composer not resizing after a change of orientation #7126

Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 29, 2022

RPReplay_Final1669739546.MP4

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 11.73% // Head: 11.73% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (198f002) compared to base (7e52aeb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7126   +/-   ##
========================================
  Coverage    11.73%   11.73%           
========================================
  Files         1620     1620           
  Lines       159288   159282    -6     
  Branches     64811    64806    -5     
========================================
+ Hits         18687    18689    +2     
  Misses      139957   139957           
+ Partials       644      636    -8     
Flag Coverage Δ
unittests 5.94% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.swift 0.00% <0.00%> (ø)
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Velin92 Velin92 merged commit 7947a73 into develop Nov 29, 2022
@Velin92 Velin92 deleted the mauroromito/7124_fix_height_resizing_when_device_is_rotated branch November 29, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich Text Editor: When rotating the device the height of the composer is not recalculated
2 participants