Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for MSC3881 #6789

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Added support for MSC3881 #6789

merged 3 commits into from
Oct 4, 2022

Conversation

gileluard
Copy link
Contributor

resolves #6787

Simulator Screen Shot - iPhone 12 Pro - 2022-10-03 at 13 45 09

@gileluard gileluard requested review from a team and pixlwave and removed request for a team October 3, 2022 11:45
@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited
Loading

Codecov Report

Base: 10.02% // Head: 5.97% // Decreases project coverage by -4.05% ⚠️

Coverage data is based on head (0ecbf82) compared to base (b5184fa).
Patch coverage: 16.44% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #6789      +/-   ##
===========================================
- Coverage    10.02%    5.97%   -4.06%     
===========================================
  Files         1490     1502      +12     
  Lines       150803   151548     +745     
  Branches     60857    61106     +249     
===========================================
- Hits         15120     9051    -6069     
- Misses      135130   142091    +6961     
+ Partials       553      406     -147
Impacted Files Coverage Δ
Config/BuildSettings.swift 43.07% <ø> (ø)
Riot/Managers/Call/CallPresenter.swift 1.08% <0.00%> (ø)
...ing/KeyVerificationVerifyByScanningViewModel.swift 0.00% <0.00%> (ø)
...erification/User/UserVerificationCoordinator.swift 0.00% <0.00%> (ø)
...r/UserVerificationCoordinatorBridgePresenter.swift 0.00% <0.00%> (ø)
...ules/MatrixKit/Models/Room/MXKRoomBubbleCellData.m 15.95% <0.00%> (ø)
...t/Views/EncryptionInfoView/MXKEncryptionInfoView.m 0.00% <0.00%> (ø)
...s/Room/Attachements/MXKAttachmentsViewController.m 0.00% <0.00%> (ø)
...m/Members/Detail/RoomMemberDetailsViewController.m 0.00% <0.00%> (ø)
...lineCells/Encryption/RoomEncryptedDataBubbleCell.m 0.00% <0.00%> (ø)
... and 602 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pixlwave
pixlwave approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of small thoughts inline :)

Riot/Managers/Call/CallPresenter.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/UserSessions/Coordinator/UserSessionsFlowCoordinator.swift Outdated Show resolved Hide resolved
.../Modules/UserSessions/UserSessionOverview/Service/MatrixSDK/UserSessionOverviewService.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/UserSessions/UserSessionOverview/View/UserSessionOverviewToggleCell.swift Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 3, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/KiCwLn

@gileluard
Added support for MSC3881
0ecbf82 
- Update after review
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gileluard gileluard merged commit c8b1657 into develop Oct 4, 2022
@gileluard gileluard deleted the gil/6787-Add_support_for_MSC3881 branch October 4, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for MSC3881
2 participants
@gileluard @pixlwave