-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include concrete device model in user agent (PSG-754) #6761
Conversation
@ismailgulek I hope you don't mind me assigning you directly since you already reviewed matrix-org/matrix-ios-sdk#1576 and this is essentially just a port. 😇 I rewrote AlamoFire's user agent code to Swift this time because, unlike in the SDK, all other involved files were already Swift, too. |
@@ -31,6 +31,9 @@ targets: | |||
platform: iOS | |||
type: app-extension | |||
|
|||
dependencies: | |||
- package: DeviceKit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little unfortunate to have to bundle this in all the extensions but I think we want the same user agent also for any networking done from extensions and luckily DeviceKit is rather small.
Codecov ReportBase: 10.04% // Head: 10.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6761 +/- ##
========================================
Coverage 10.04% 10.04%
========================================
Files 1490 1490
Lines 150805 150864 +59
Branches 60858 60870 +12
========================================
+ Hits 15143 15160 +17
- Misses 135108 135147 +39
- Partials 554 557 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of inline comments, otherwise lgtm.
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/oFjFTy |
Hm, looks like
|
Kudos, SonarCloud Quality Gate passed! |
Fixes: #6742
Pull Request Checklist