Timeline composer layout loop fix #6743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wvKBbd |
Codecov ReportBase: 9.96% // Head: 9.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6743 +/- ##
===========================================
- Coverage 9.96% 9.95% -0.01%
===========================================
Files 1484 1484
Lines 150507 150561 +54
Branches 60751 60769 +18
===========================================
+ Hits 14992 14994 +2
- Misses 134961 135013 +52
Partials 554 554
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Kudos, SonarCloud Quality Gate passed!
|
ismailgulek
added a commit
that referenced
this pull request
Sep 20, 2022
* Device manager: add user sessions overview current session strings. * Create UserSessionCardView to display session informations. * UserSessionsOverview: Handle current session section view. * Prepare for new sprint * Dismiss the launching screen when clearing cache. * Fix crash when previewing a room. * Fix typo in empty state * Code review fixes * Update swift-ogg and add changelog * Fix crash on logout from too much wrong pin codes * Update changelog to original issue * Disable unnecessary network breadcrumbs in Sentry * Changelog * Fix login crash on Xcode 14 builds Fixes #6722 * Put the session creator on the main actor instead. This covers all login and registration options. * Only disable the composer if the room is yet to be created. * Add missing source views for iPad. * New App Layout: fixed rooms list doesn't update after log out and log into another account * New layout: Fixed low priority rooms titles obscured by bottom bar when side scrolling * Fix replied event content parsing for nested replies * Fixed failed to join room (was not legal room) * Timeline composer layout loop fix (#6743) * Publish suitable view height for user suggestions * Update container view height * Add changelog * Fix user suggestions layout for pre iOS 16 * version++ Co-authored-by: SBiOSoftWhare <[email protected]> Co-authored-by: Doug <[email protected]> Co-authored-by: Germain Souquet <[email protected]> Co-authored-by: Stefan Ceriu <[email protected]> Co-authored-by: Aleksandrs Proskurins <[email protected]> Co-authored-by: David Langley <[email protected]> Co-authored-by: aringenbach <[email protected]> Co-authored-by: aringenbach <[email protected]> Co-authored-by: Andy Uhnak <[email protected]> Co-authored-by: Johannes Marbach <[email protected]> Co-authored-by: Gil Eluard <[email protected]> Co-authored-by: Gil Eluard <[email protected]> Co-authored-by: gulekismail <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6734
Fixes #6735