Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App Layout: fixed rooms list doesn't update after log out and log… #6740

Conversation

gileluard
Copy link
Contributor

resolves #6739

@gileluard gileluard requested review from a team and pixlwave and removed request for a team September 19, 2022 11:39
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 9.96% // Head: 9.90% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (692ece1) compared to base (60c8be0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6740      +/-   ##
===========================================
- Coverage     9.96%    9.90%   -0.06%     
===========================================
  Files         1484     1484              
  Lines       150509   150512       +3     
  Branches     60753    60750       -3     
===========================================
- Hits         14995    14908      -87     
- Misses      134960   135058      +98     
+ Partials       554      546       -8     
Impacted Files Coverage Δ
...Modules/Home/AllChats/AllChatsViewController.swift 28.43% <0.00%> (-0.18%) ⬇️
...SplashScreen/OnboardingSplashScreenViewModel.swift 11.53% <0.00%> (-42.31%) ⬇️
...calAuthentication/LocalAuthenticationService.swift 27.27% <0.00%> (-27.28%) ⬇️
Riot/Modules/Application/AppDelegate.swift 50.76% <0.00%> (-4.62%) ⬇️
...ing/SplashScreen/View/OnboardingSplashScreen.swift 54.66% <0.00%> (-4.00%) ⬇️
...xKit/Controllers/MXKAuthenticationViewController.m 17.04% <0.00%> (-1.92%) ⬇️
...anagers/PushNotification/PushNotificationService.m 10.41% <0.00%> (-1.05%) ⬇️
Riot/Modules/Application/LegacyAppDelegate.m 12.76% <0.00%> (-0.64%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...ot/Modules/Home/AllChats/AllChatsCoordinator.swift 22.03% <0.00%> (-0.04%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4GNRne

@gileluard gileluard merged commit d68e3ab into develop Sep 19, 2022
@gileluard gileluard deleted the gil/6739-New_App_Layout_rooms_list_doesn_t_update_after_log_out_and_log_into_another_account branch September 19, 2022 15:36
@pixlwave
Copy link
Member

Ahhh, displayList can take nil, so much for my comment on #6711...

Thanks for fixing this one :)

@gileluard
Copy link
Contributor Author

I tested it and it works at list in this case. This way a new data source is created when the user logs in.

@Johennes
Copy link
Contributor

Thanks for fixing this @gileluard! 🙏

@gileluard
Copy link
Contributor Author

You're more than welcome @Johennes ! I should have thought about this way before

@pixlwave pixlwave removed their request for review September 20, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New App Layout: rooms list doesn't update after log out and log into another account
4 participants